Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The problem is that the state of the EMGFilters filters is stored in the global variables LPF, HPF and AHF. These being globals means that all instances of EMGFilters share their internal state. #7

Open
allrobot opened this issue Apr 19, 2022 · 1 comment · May be fixed by #4
Open

The problem is that the state of the EMGFilters filters is stored in the global variables LPF, HPF and AHF. These being globals means that all instances of EMGFilters share their internal state. #7

allrobot opened this issue Apr 19, 2022 · 1 comment · May be fixed by #4

Comments

@allrobot
Copy link

The problem is that the state of the EMGFilters filters is stored in the global variables LPF, HPF and AHF. These being globals means that all instances of EMGFilters share their internal state.

The filter state should be stored as instance data. Otherwise all instances effectively share the same filter.

Originally posted by @edgar-bonet in #3 (comment)

@edgar-bonet Oh. I'm sorry. Because of your fix, I thought the problem was solved and closed it. It seems that I did not follow the Github rules. Now I re-open the issue.
@edgar-bonet
Copy link

@allrobot: #4 is a proposed fix. The problem will be solved if/when a fix is accepted by the owners of the project and merged into the master branch.

@edgar-bonet edgar-bonet linked a pull request Apr 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the filter state instance data edgar-bonet/EMGFilters
2 participants
@edgar-bonet @allrobot