Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add pettingzoo requirement & upgrade to latest version #17

Open
elliottower opened this issue Mar 25, 2023 · 2 comments

Comments

@elliottower
Copy link

Hi, I just wanted to say this is an awesome project and I'm excited to try it out.

I installed via the instructions but it doesn't install pettingzoo, even though there are examples using it. Obviously users can just install it themselves but I think it should probably be listed as an extra. As a note, there is a new release upcoming in the next few weeks so it could wait until that, or just list pettingzoo>=1.22.4 (most recent version).

If you need any help working out kinks due to different versions feel free to ask, there were some breaking changes in the past 6 months or so, so if you previously used an older version like 1.15.0 it requires a bit of updates to fix. The previous API returned done in the step() function, whereas the new one returns truncated and terminated (matching gymnasium). There is a migration guide for gymnasium explaining the changes further, the steps should be basically the same (we're working on making resources for updating old PettingZoo repositories as well): https://gymnasium.farama.org/content/migration-guide/

@benellis3
Copy link
Collaborator

Hi. Thanks very much for raising an issue! I'm not sure about the current status of pettingzoo support. I will carve out a day and try to get it working though. I don't think it should be too tricky given the current framework.

Thanks for the tips I'll let you know how I get on 😄 .

@elliottower
Copy link
Author

Hi. Thanks very much for raising an issue! I'm not sure about the current status of pettingzoo support. I will carve out a day and try to get it working though. I don't think it should be too tricky given the current framework.

Thanks for the tips I'll let you know how I get on 😄 .

Great to hear, thanks! Excited to test it out once you are able to get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants