Upgrade PHPLint to v9

[llaville]

I think now we have PHP 8.1 as base version of MegaLinter v6, it's time to upgrade PHPLint from version 5.5 to 9.0

As I'm author of refactoring code to major version v9 of PHPLint, I wanted to said :

• previous versions will be not supported in future months
• latest version 9.0.4 is now stable since at least one month

Now about MegaLinter v6.

I've tried the recent version 6.21.0

 ----------------------------------------------------------------------------------------------------
------------------------------------ MegaLinter, by OX Security ------------------------------------
----------------------------------------------------------------------------------------------------
 - Image Creation Date: 2023-03-26T14:04:33Z
 - Image Revision: 66108018d9c2160896d8cf34d56f341592d23ffd
 - Image Version: 66108018d9c2160896d8cf34d56f341592d23ffd
----------------------------------------------------------------------------------------------------
The MegaLinter documentation can be found at:
 - https://megalinter.io/66108018d9c2160896d8cf34d56f341592d23ffd

And still have wrong links (that lead to 404) in Console Reporter on each linter
E.g: chunk of screenshot

Strange because, when I rebuilt locally the PHP flavor, I've no such results. See in chunk of screenshot

My local command was :

docker build -f flavors/php/Dockerfile --secret id=GITHUB_TOKEN,env=GITHUB_TOKEN .

With: Docker version 23.0.1, build a5ee5b1 (docker buildkit enabled)

About MegaLinter v6 upgrade it will be more simple now, we previously used Composer only for PHPLint installation.
We can now remove it because it's no more necessary : PHIVE is able to install PHPLint v9

• https://github.com/oxsecurity/megalinter/blob/v6.21.0/megalinter/descriptors/php.megalinter-descriptor.yml#L20
• https://github.com/oxsecurity/megalinter/blob/v6.21.0/megalinter/descriptors/php.megalinter-descriptor.yml#L38

And PHIVE installation is much easier
Replace
https://github.com/oxsecurity/megalinter/blob/v6.21.0/megalinter/descriptors/php.megalinter-descriptor.yml#L38
By

    install:
      dockerfile:
        - |
          RUN GITHUB_AUTH_TOKEN="$(cat /run/secrets/GITHUB_TOKEN)" && export GITHUB_AUTH_TOKEN && phive --no-progress install overtrue/phplint --force-accept-unsigned -g 

[llaville]

FYI: When I've rebuild PHP flavor locally, I got this final results (with warnings)

[nvuillam]

@llaville thanks a lot for the initiative :)

About the wrong links, it's only during dev branch build, not beta or release, right ?

About the warnings: it's because we join the RUN instructions and add comments within the Dockerfile and it seems it's forbidden... we should replace them by "echo" someday :)

[llaville]

About the wrong links, it's only during dev branch build, not beta or release, right ?

It's about official (suppose stable) release 6.21.0

For docker image oxsecurity/megalinter-php:v6, digest sha256:22508bb3ed78acc790ee9b3c7009ae119ee095b339fa45c9ca0a529e115150c0

[nvuillam]

https://github.com/hardisgroupcom/sfdx-hardis/actions/runs/4529862900/jobs/7978081998

Ouch indeed that's ugly :o :o

Seems like a regression, I'll check that tonight

[llaville]

Seems like a regression, I'll check that tonight

Exists since 6.20.0 (see #2425)

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.