From 5dd88c853de515dfa1e0879c497fc95e4d546410 Mon Sep 17 00:00:00 2001 From: Rain Date: Tue, 11 Aug 2026 13:48:53 -0700 Subject: [PATCH] [spr] changes to main this commit is based on Created using spr 1.3.6-beta.1 [skip ci] --- openapi/wicketd.json | 23 --------------------- wicket/src/wicketd.rs | 4 ++-- wicketd-api/src/lib.rs | 13 ------------ wicketd/src/commission/mod.rs | 2 +- wicketd/src/http_entrypoints.rs | 36 --------------------------------- 5 files changed, 3 insertions(+), 75 deletions(-) diff --git a/openapi/wicketd.json b/openapi/wicketd.json index 5b7a800aefe..23271794b23 100644 --- a/openapi/wicketd.json +++ b/openapi/wicketd.json @@ -319,29 +319,6 @@ "$ref": "#/components/responses/Error" } } - }, - "post": { - "summary": "Run rack setup.", - "description": "Will return an error if not all of the rack setup configuration has been populated.", - "operationId": "post_run_rack_setup", - "responses": { - "200": { - "description": "successful operation", - "content": { - "application/json": { - "schema": { - "$ref": "#/components/schemas/RackInitUuid" - } - } - } - }, - "4XX": { - "$ref": "#/components/responses/Error" - }, - "5XX": { - "$ref": "#/components/responses/Error" - } - } } }, "/rack-setup/config": { diff --git a/wicket/src/wicketd.rs b/wicket/src/wicketd.rs index 16fd123def8..2a020b4536b 100644 --- a/wicket/src/wicketd.rs +++ b/wicket/src/wicketd.rs @@ -290,10 +290,10 @@ impl WicketdManager { fn start_rack_initialization(&self) { let log = self.log.clone(); - let addr = self.wicketd_addr; + let addr = self.commission_addr; let events_tx = self.events_tx.clone(); tokio::spawn(async move { - let client = create_wicketd_client(&log, addr, WICKETD_TIMEOUT); + let client = create_commission_client(&log, addr, WICKETD_TIMEOUT); let response = match client.post_run_rack_setup().await { Ok(_) => Ok(()), Err(error) => Err(error.to_string()), diff --git a/wicketd-api/src/lib.rs b/wicketd-api/src/lib.rs index 1e560596ee9..b7e7956fd24 100644 --- a/wicketd-api/src/lib.rs +++ b/wicketd-api/src/lib.rs @@ -11,7 +11,6 @@ use dropshot::RequestContext; use dropshot::StreamingBody; use dropshot::TypedBody; use gateway_client::types::IgnitionCommand; -use omicron_uuid_kinds::RackInitUuid; use schemars::JsonSchema; use semver::Version; use serde::Deserialize; @@ -186,18 +185,6 @@ pub trait WicketdApi { rqctx: RequestContext, ) -> Result, HttpError>; - /// Run rack setup. - /// - /// Will return an error if not all of the rack setup configuration has - /// been populated. - #[endpoint { - method = POST, - path = "/rack-setup" - }] - async fn post_run_rack_setup( - rqctx: RequestContext, - ) -> Result, HttpError>; - /// A status endpoint used to report high level information known to /// wicketd. /// diff --git a/wicketd/src/commission/mod.rs b/wicketd/src/commission/mod.rs index bbd03d2398e..a3c41734d03 100644 --- a/wicketd/src/commission/mod.rs +++ b/wicketd/src/commission/mod.rs @@ -5,7 +5,7 @@ //! The stable wicketd commissioning API. //! //! This API is used by automated tooling such as rkdeploy to commission new -//! racks. It is a reduced subset of the full, unstable wicketd API. +//! racks. //! //! **Automation must always use the stable API!** //! diff --git a/wicketd/src/http_entrypoints.rs b/wicketd/src/http_entrypoints.rs index 064d88fc335..f730747ec1f 100644 --- a/wicketd/src/http_entrypoints.rs +++ b/wicketd/src/http_entrypoints.rs @@ -15,7 +15,6 @@ use crate::mgs::GetInventoryResponse as GetMgsInventoryResponse; use crate::mgs::records_to_mgs_inventory; use crate::multirack_config::CurrentMultirackJoinConfig; use crate::transceivers::GetTransceiversResponse; -use bootstrap_agent_lockstep_client::ClientInfo as _; use bootstrap_agent_lockstep_types::RackOperationStatus; use dropshot::ApiDescription; use dropshot::HttpError; @@ -26,7 +25,6 @@ use dropshot::RequestContext; use dropshot::StreamingBody; use dropshot::TypedBody; use internal_dns_resolver::Resolver; -use omicron_uuid_kinds::RackInitUuid; use sled_agent_types::early_networking::SwitchSlot; use slog::o; use std::sync::Arc; @@ -310,40 +308,6 @@ impl WicketdApi for WicketdApiImpl { Ok(HttpResponseOk(op_status)) } - async fn post_run_rack_setup( - rqctx: RequestContext, - ) -> Result, HttpError> { - let ctx = rqctx.context(); - let log = &rqctx.log; - - let client = ba_lockstep_client(ctx); - let request = { - let mut config = ctx.rss_or_multirack_join_config.lock().unwrap(); - - let rss_config = config.rss_config_mut_or_conflict( - "cannot run rack setup when not preparing for RSS", - )?; - - rss_config.start_rss_request(&ctx.bootstrap_peers, log).map_err( - |err| HttpError::for_bad_request(None, format!("{err:#}")), - )? - }; - - slog::info!( - ctx.log, - "Sending RSS initialize request to {}", - client.baseurl() - ); - - let init_id = client - .rack_initialize(&request) - .await - .map_err(|err| ba_lockstep_error_to_http(err, "rack setup"))? - .into_inner(); - - Ok(HttpResponseOk(init_id)) - } - async fn get_inventory( rqctx: RequestContext, body_params: TypedBody,