Comments about external IPs

Author: smklein

nexus/db-model/src/project.rs

@@ -92,7 +92,10 @@ impl DatastoreCollectionConfig<IpPool> for Project {
     type CollectionIdColumn = ip_pool::dsl::project_id;
 }
 
-// TODO(https://github.com/oxidecomputer/omicron/issues/1482): Not yet utilized
+// TODO(https://github.com/oxidecomputer/omicron/issues/1482): Not yet utilized,
+// but needed for project deletion safety.
+// TODO(https://github.com/oxidecomputer/omicron/issues/1334): Cannot be
+// utilized until floating IPs are implemented.
 impl DatastoreCollectionConfig<ExternalIp> for Project {
     type CollectionId = Uuid;
     type GenerationNumberColumn = project::dsl::rcgen;

nexus/tests/integration_tests/projects.rs

@@ -442,4 +442,9 @@ async fn test_project_deletion_with_ip_pool(
     delete_project(&url, &client).await;
 }
 
-// TODO: external IP
+// TODO(https://github.com/oxidecomputer/omicron/issues/1334): Once floating IPs
+// are implemented, we should:
+// - Create a project-scoped external IP
+// - Attempt to delete the project (show that we cannot)
+// - Delete the external IP
+// - Delete the project