Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video call auto rotates, when auto rotate is disabled #1085

Closed
1 task done
WardPearce opened this issue Jan 22, 2023 · 3 comments
Closed
1 task done

Video call auto rotates, when auto rotate is disabled #1085

WardPearce opened this issue Jan 22, 2023 · 3 comments
Labels
bug Something isn't working good-first-issue Good issue for first time contributors

Comments

@WardPearce
Copy link

Code of conduct

Describe the bug

Disabling auto rotate in my settings, doesn't disable auto rotate in video calls.

To reproduce

Steps to reproduce the behavior:
Disable auto rotate, start a video call. Tilt your device slightly making it unusable.

Smartphone (please complete the following information):

  • Device: Google Pixel 6, Samsung Flip & other devices of friends.
  • OS: Android
  • 1.16.3
@WardPearce WardPearce added the bug Something isn't working label Jan 22, 2023
@KeeJef KeeJef added the good-first-issue Good issue for first time contributors label Feb 7, 2023
@hjubb
Copy link

hjubb commented Feb 14, 2023

This one we can probably add some system specific check for whether auto-rotate is enabled (not sure if it exists or what it's called off the top of my head) in the onCreate of the WebRtcCallActivity and if it is enabled only then call rotationListener.enable(), same for the disable() call in onDestroy maybe?

@rugveddarwhekar
Copy link

@hjubb Please check my attempt at fixing this: PR

@ThomasSession
Copy link
Collaborator

Thanks for the PR. We merged in the changes and they will be made in the next available app update coming out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good issue for first time contributors
Projects
None yet
Development

No branches or pull requests

5 participants