From 3f7faed095f1390b1222e4ed9636f01080952b4e Mon Sep 17 00:00:00 2001
From: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Date: Mon, 10 Feb 2025 06:22:08 +0000
Subject: [PATCH] feat(minifier): remove unused function expression with name
 by remove_dead_code (#8996)

I think whether the `name` exists or not does not affect whether the function expression can be removed or not because the name can only be referenced inside that function.
---
 crates/oxc_minifier/src/peephole/remove_dead_code.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crates/oxc_minifier/src/peephole/remove_dead_code.rs b/crates/oxc_minifier/src/peephole/remove_dead_code.rs
index 3b13c310a0eb5..96a4ad529ae5c 100644
--- a/crates/oxc_minifier/src/peephole/remove_dead_code.rs
+++ b/crates/oxc_minifier/src/peephole/remove_dead_code.rs
@@ -334,10 +334,9 @@ impl<'a, 'b> PeepholeOptimizations {
                     ctx.ast.expression_sequence(template_lit.span, expressions),
                 ))
             }
-            Expression::FunctionExpression(function_expr) if function_expr.id.is_none() => {
+            Expression::FunctionExpression(_) | Expression::ArrowFunctionExpression(_) => {
                 Some(ctx.ast.statement_empty(stmt.span))
             }
-            Expression::ArrowFunctionExpression(_) => Some(ctx.ast.statement_empty(stmt.span)),
             // `typeof x` -> ``
             Expression::UnaryExpression(unary_expr)
                 if unary_expr.operator.is_typeof()
@@ -648,6 +647,7 @@ mod test {
         test("{x==3}", "x == 3");
         test("{`hello ${foo}`}", "`hello ${foo}`");
         test("{ (function(){x++}) }", "");
+        test("{ (function foo(){x++; foo()}) }", "");
         test("function f(){return;}", "function f(){}");
         test("function f(){return 3;}", "function f(){return 3}");
         test("function f(){if(x)return; x=3; return; }", "function f(){if(x)return; x=3; }");