Skip to content

fix(minifier): unreachable error when compressing string literal arrays with .split() #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 31, 2025
Merged

fix(minifier): unreachable error when compressing string literal arrays with .split() #8806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,10 +950,9 @@ impl<'a> LatePeepholeOptimizations {

let Expression::ArrayExpression(array) = expr else { unreachable!() };

let is_all_string = array
.elements
.iter()
.all(|element| element.as_expression().is_some_and(Expression::is_string_literal));
let is_all_string = array.elements.iter().all(|element| {
element.as_expression().is_some_and(|expr| matches!(expr, Expression::StringLiteral(_)))
});
if !is_all_string {
return None;
}
Expand Down Expand Up @@ -1323,13 +1322,15 @@ mod test {

test_same_with_longer_args("'1','2','3','4'");
test_same_with_longer_args("'1','2','3','4','5'");
test_same_with_longer_args("`1${a}`,'2','3','4','5','6'");
test_with_longer_args("'1','2','3','4','5','6'", "123456", "");
test_with_longer_args("'1','2','3','4','5','00'", "1.2.3.4.5.00", ".");
test_with_longer_args("'1','2','3','4','5','6','7'", "1234567", "");
test_with_longer_args("'1','2','3','4','5','6','00'", "1.2.3.4.5.6.00", ".");
test_with_longer_args("'.,',',',',',',',',',','", ".,(,(,(,(,(,", "(");
test_with_longer_args("',,','.',',',',',',',','", ",,(.(,(,(,(,", "(");
test_with_longer_args("'a,','.',',',',',',',','", "a,(.(,(,(,(,", "(");
test_with_longer_args("`1`,'2','3','4','5','6'", "123456", "");

// all possible delimiters used, leave it alone
test_same_with_longer_args("'.', ',', '(', ')', ' '");
Expand Down
Loading