diff --git a/crates/oxc_minifier/src/ast_passes/convert_to_dotted_properties.rs b/crates/oxc_minifier/src/ast_passes/convert_to_dotted_properties.rs index e2608657b6812..09bc5888efe87 100644 --- a/crates/oxc_minifier/src/ast_passes/convert_to_dotted_properties.rs +++ b/crates/oxc_minifier/src/ast_passes/convert_to_dotted_properties.rs @@ -309,7 +309,7 @@ mod test { test_same("x['-0x1']"); test("x['2147483647']", "x[2147483647]"); test_same("x['2147483648']"); - test_same("x['-2147483648']"); + test("x['-2147483648']", "x[-2147483648]"); test_same("x['-2147483649']"); } } diff --git a/crates/oxc_minifier/src/ctx.rs b/crates/oxc_minifier/src/ctx.rs index 8ffedabf05f7f..d9e972b5b0019 100644 --- a/crates/oxc_minifier/src/ctx.rs +++ b/crates/oxc_minifier/src/ctx.rs @@ -94,21 +94,24 @@ impl<'a> Ctx<'a, '_> { let bytes = s.as_bytes(); if bytes[0] == b'-' && s.len() > 1 { is_negative = true; + int_value = -int_value; start += 1; } if bytes[start] == b'0' && s.len() > 1 { return None; } for b in &bytes[start..] { - if b.is_ascii_digit() { - int_value = - int_value.checked_mul(10).and_then(|v| v.checked_add(i32::from(b & 15)))?; - } else { + if !b.is_ascii_digit() { return None; } - } - if is_negative { - int_value = -int_value; + int_value = int_value.checked_mul(10).and_then(|v| { + let n = i32::from(b & 15); + if is_negative { + v.checked_sub(n) + } else { + v.checked_add(n) + } + })?; } Some(f64::from(int_value)) } diff --git a/tasks/minsize/minsize.snap b/tasks/minsize/minsize.snap index 93506b0f41dc1..8d1ac6f1e56b7 100644 --- a/tasks/minsize/minsize.snap +++ b/tasks/minsize/minsize.snap @@ -7,7 +7,7 @@ Original | minified | minified | gzip | gzip | Fixture 287.63 kB | 90.08 kB | 90.07 kB | 32.03 kB | 31.95 kB | jquery.js -342.15 kB | 118.11 kB | 118.14 kB | 44.44 kB | 44.37 kB | vue.js +342.15 kB | 118.14 kB | 118.14 kB | 44.45 kB | 44.37 kB | vue.js 544.10 kB | 71.76 kB | 72.48 kB | 26.15 kB | 26.20 kB | lodash.js @@ -15,13 +15,13 @@ Original | minified | minified | gzip | gzip | Fixture 1.01 MB | 460.17 kB | 458.89 kB | 126.76 kB | 126.71 kB | bundle.min.js -1.25 MB | 652.80 kB | 646.76 kB | 163.53 kB | 163.73 kB | three.js +1.25 MB | 652.88 kB | 646.76 kB | 163.54 kB | 163.73 kB | three.js -2.14 MB | 725.52 kB | 724.14 kB | 180.05 kB | 181.07 kB | victory.js +2.14 MB | 725.56 kB | 724.14 kB | 180.06 kB | 181.07 kB | victory.js -3.20 MB | 1.01 MB | 1.01 MB | 331.77 kB | 331.56 kB | echarts.js +3.20 MB | 1.01 MB | 1.01 MB | 332.02 kB | 331.56 kB | echarts.js -6.69 MB | 2.32 MB | 2.31 MB | 492.62 kB | 488.28 kB | antd.js +6.69 MB | 2.32 MB | 2.31 MB | 492.64 kB | 488.28 kB | antd.js -10.95 MB | 3.49 MB | 3.49 MB | 907.11 kB | 915.50 kB | typescript.js +10.95 MB | 3.49 MB | 3.49 MB | 907.34 kB | 915.50 kB | typescript.js