From 05be1fc639b4f0e50810cd8dac0399c83723785a Mon Sep 17 00:00:00 2001 From: Boshen <1430279+Boshen@users.noreply.github.com> Date: Wed, 1 Jan 2025 05:44:01 +0000 Subject: [PATCH] fix(minifier): remove incorrect fold `Expression::AssignmentExpression` (#8211) --- crates/oxc_ecmascript/src/constant_evaluation/mod.rs | 7 ------- tasks/minsize/minsize.snap | 4 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/crates/oxc_ecmascript/src/constant_evaluation/mod.rs b/crates/oxc_ecmascript/src/constant_evaluation/mod.rs index d61b729cd0b87..ce365fc68d8a0 100644 --- a/crates/oxc_ecmascript/src/constant_evaluation/mod.rs +++ b/crates/oxc_ecmascript/src/constant_evaluation/mod.rs @@ -124,13 +124,6 @@ pub trait ConstantEvaluation<'a> { _ => None, } } - Expression::AssignmentExpression(assign_expr) => { - match assign_expr.operator { - AssignmentOperator::LogicalAnd | AssignmentOperator::LogicalOr => None, - // For ASSIGN, the value is the value of the RHS. - _ => self.get_boolean_value(&assign_expr.right), - } - } expr => { use crate::ToBoolean; expr.to_boolean() diff --git a/tasks/minsize/minsize.snap b/tasks/minsize/minsize.snap index 0dc9af622eab3..6d06107f38210 100644 --- a/tasks/minsize/minsize.snap +++ b/tasks/minsize/minsize.snap @@ -11,7 +11,7 @@ Original | minified | minified | gzip | gzip | Fixture 544.10 kB | 71.84 kB | 72.48 kB | 26.19 kB | 26.20 kB | lodash.js -555.77 kB | 273.48 kB | 270.13 kB | 90.94 kB | 90.80 kB | d3.js +555.77 kB | 273.58 kB | 270.13 kB | 90.98 kB | 90.80 kB | d3.js 1.01 MB | 460.75 kB | 458.89 kB | 126.88 kB | 126.71 kB | bundle.min.js @@ -19,7 +19,7 @@ Original | minified | minified | gzip | gzip | Fixture 2.14 MB | 726.71 kB | 724.14 kB | 180.25 kB | 181.07 kB | victory.js -3.20 MB | 1.01 MB | 1.01 MB | 332.13 kB | 331.56 kB | echarts.js +3.20 MB | 1.01 MB | 1.01 MB | 332.14 kB | 331.56 kB | echarts.js 6.69 MB | 2.32 MB | 2.31 MB | 493.00 kB | 488.28 kB | antd.js