From 7e0f7eb67b1821eb44ad308235f28436c67d19ca Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Mon, 9 Dec 2024 16:09:24 +0000 Subject: [PATCH] refactor(transformer/class-properties): prefer `contains` to `intersects` for bitflags (#7747) Tiny refactor. `contains` is clearer than `intersects`, and they produce equivalent assembly when argument is a single flag value, and statically knowable. https://godbolt.org/z/bTdfbv3f8 --- crates/oxc_transformer/src/es2022/class_properties/class.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/oxc_transformer/src/es2022/class_properties/class.rs b/crates/oxc_transformer/src/es2022/class_properties/class.rs index 597d4afd5fbf6..eb418a061c0e5 100644 --- a/crates/oxc_transformer/src/es2022/class_properties/class.rs +++ b/crates/oxc_transformer/src/es2022/class_properties/class.rs @@ -754,7 +754,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> { // Test for it in first pass over class elements, and avoid temp vars where possible. match ctx.symbols().get_reference(ident.reference_id()).symbol_id() { Some(symbol_id) => { - ctx.symbols().get_flags(symbol_id).intersects(SymbolFlags::ConstVariable) + ctx.symbols().get_flags(symbol_id).contains(SymbolFlags::ConstVariable) || ctx .symbols() .get_resolved_references(symbol_id)