From 57685b28e865f50b4127a6bb94059c1d24a8bafe Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Wed, 23 Oct 2024 13:26:23 +0000 Subject: [PATCH] refactor(transformer/react-refresh): unwrap `BindingIdentifier::symbol_id` (#6817) Nit. `BindingIdentifier::symbol_id` should always be `Some`. Panic rather than exiting early if it's not. --- crates/oxc_transformer/src/react/refresh.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/oxc_transformer/src/react/refresh.rs b/crates/oxc_transformer/src/react/refresh.rs index 6119eb7f83ebb..2935843e7dbe1 100644 --- a/crates/oxc_transformer/src/react/refresh.rs +++ b/crates/oxc_transformer/src/react/refresh.rs @@ -784,7 +784,7 @@ impl<'a, 'ctx> ReactRefresh<'a, 'ctx> { let declarator = decl.declarations.first_mut().unwrap_or_else(|| unreachable!()); let init = declarator.init.as_mut()?; let id = declarator.id.get_binding_identifier()?; - let symbol_id = id.symbol_id.get()?; + let symbol_id = id.symbol_id.get().unwrap(); if !is_componentish_name(&id.name) { return None;