From 115ccc941eeb873727596e55fd4a465133709f17 Mon Sep 17 00:00:00 2001
From: 7086cmd <54303040+7086cmd@users.noreply.github.com>
Date: Thu, 3 Oct 2024 00:16:05 +0000
Subject: [PATCH] feat(minifier): bitwise not in exceeded value. (#6235)

```rs
        test("x = ~2147483658.0", "x = 2147483637");
        test("x = ~-2147483658", "x = -2147483639");
```

Used `wrapping_neg`, and maybe it is a great solution for #6161.
---
 .../src/ast_passes/peephole_fold_constants.rs | 23 ++++++++-----------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/crates/oxc_minifier/src/ast_passes/peephole_fold_constants.rs b/crates/oxc_minifier/src/ast_passes/peephole_fold_constants.rs
index aadea7a4d1dd8..a2e5192e4c41a 100644
--- a/crates/oxc_minifier/src/ast_passes/peephole_fold_constants.rs
+++ b/crates/oxc_minifier/src/ast_passes/peephole_fold_constants.rs
@@ -140,11 +140,8 @@ impl<'a> PeepholeFoldConstants {
         expr: &mut UnaryExpression<'a>,
         ctx: &mut TraverseCtx<'a>,
     ) -> Option<Expression<'a>> {
-        fn is_within_i32_range(x: f64) -> bool {
-            x.is_finite()
-                && x.fract() == 0.0
-                && x >= f64::from(i32::MIN)
-                && x <= f64::from(i32::MAX)
+        fn is_valid(x: f64) -> bool {
+            x.is_finite() && x.fract() == 0.0
         }
         match expr.operator {
             UnaryOperator::Void => self.try_reduce_void(expr, ctx),
@@ -198,7 +195,7 @@ impl<'a> PeepholeFoldConstants {
                         )
                     })
                 }
-                Expression::NumericLiteral(n) => is_within_i32_range(n.value).then(|| {
+                Expression::NumericLiteral(n) => is_valid(n.value).then(|| {
                     let value = !n.value.to_js_int_32();
                     ctx.ast.expression_numeric_literal(
                         SPAN,
@@ -234,8 +231,8 @@ impl<'a> PeepholeFoldConstants {
                         UnaryOperator::UnaryNegation if un.argument.is_number() => {
                             // `-~1` -> `2`
                             if let Expression::NumericLiteral(n) = &mut un.argument {
-                                is_within_i32_range(n.value).then(|| {
-                                    let value = !(-n.value.to_js_int_32());
+                                is_valid(n.value).then(|| {
+                                    let value = !n.value.to_js_int_32().wrapping_neg();
                                     ctx.ast.expression_numeric_literal(
                                         SPAN,
                                         value.into(),
@@ -1371,8 +1368,8 @@ mod test {
         test("a=+-7", "a=-7");
         // test("a=+.5", "a=.5");
 
-        // test("a=~0xffffffff", "a=0");
-        // test("a=~~0xffffffff", "a=-1");
+        test("a=~0xffffffff", "a=0");
+        test("a=~~0xffffffff", "a=-1");
         // test_same("a=~.5", PeepholeFoldConstants.FRACTIONAL_BITWISE_OPERAND);
     }
 
@@ -1404,10 +1401,8 @@ mod test {
         test_same("a = ~b");
         test_same("a = ~NaN");
         test_same("a = ~-Infinity");
-        // TODO(7086cmd) We preserve it right now, since exceeded data's ~ calculation
-        // is hard to implement within one PR.
-        // test("x = ~2147483658.0", "x = 2147483647");
-        // test("x = ~-2147483658", "x = -2147483649");
+        test("x = ~2147483658.0", "x = 2147483637");
+        test("x = ~-2147483658", "x = -2147483639");
     }
 
     #[test]