From 58d333a533de3511b7b280e35be6b27cbed574bb Mon Sep 17 00:00:00 2001
From: camchenry <1514176+camchenry@users.noreply.github.com>
Date: Tue, 24 Sep 2024 23:20:47 +0000
Subject: [PATCH] test(linter): add more test cases for disable directives
 (#6047)

- related to https://github.com/oxc-project/oxc/issues/6041
- follow-up to https://github.com/oxc-project/oxc/pull/6045

While working on the original PR, I noticed that we didn't have any pathological test cases yet for disable directives. I've added some more complex test cases here to ensure we don't regress the disable/enable behavior in the future.
---
 crates/oxc_linter/src/disable_directives.rs | 140 ++++++++++++++++++++
 1 file changed, 140 insertions(+)

diff --git a/crates/oxc_linter/src/disable_directives.rs b/crates/oxc_linter/src/disable_directives.rs
index 669d5cd967e8c..510a4053a4cfa 100644
--- a/crates/oxc_linter/src/disable_directives.rs
+++ b/crates/oxc_linter/src/disable_directives.rs
@@ -357,6 +357,84 @@ fn test() {
                 debugger;
             "
             ),
+            // Handles no spaces in comment
+            format!(
+                "debugger; //{prefix}-disable-line
+            debugger; //{prefix}-disable-line
+
+            //{prefix}-disable-next-line
+            debugger;
+
+            /*{prefix}-disable-next-line*/
+            debugger;
+
+            debugger; /*{prefix}-disable-line*/
+            
+            debugger; //{prefix}-disable-line no-debugger
+
+            //{prefix}-disable-next-line no-debugger
+            debugger;
+
+            debugger; /*{prefix}-disable-line no-debugger*/
+
+            /*{prefix}-disable-next-line no-debugger*/
+            debugger;
+        "
+            ),
+            // Handles extra spaces in comment
+            format!(
+                "debugger; //       {prefix}-disable-line
+            debugger; // \t\t {prefix}-disable-line
+
+            //         {prefix}-disable-next-line
+            debugger;
+
+            /*      {prefix}-disable-next-line        */
+            debugger;
+
+            debugger; /*    {prefix}-disable-line       */
+            
+            debugger; //            {prefix}-disable-line no-debugger
+
+            //          {prefix}-disable-next-line no-debugger
+            debugger;
+
+            debugger; /*     \t   {prefix}-disable-line no-debugger*/
+
+            /*    \t   {prefix}-disable-next-line no-debugger       */
+            debugger;
+        "
+            ),
+            // Extra commas
+            format!(
+                "
+            debugger // {prefix}-disable-line no-debugger,
+            debugger // {prefix}-disable-line ,no-debugger
+            debugger // {prefix}-disable-line no-debugger,,
+            debugger // {prefix}-disable-line ,,no-debugger,,
+            debugger // {prefix}-disable-line ,,no-debugger,,semi,,
+            debugger // {prefix}-disable-line ,,no-debugger,,no-debugger,,
+            debugger // {prefix}-disable-line ,  , ,,no-debugger, , ,
+
+            // {prefix}-disable-next-line no-debugger,
+            debugger
+            // {prefix}-disable-next-line ,no-debugger,
+            debugger
+            // {prefix}-disable-next-line no-debugger,,
+            debugger
+            // {prefix}-disable-next-line ,,no-debugger,,
+            debugger
+            // {prefix}-disable-next-line ,,no-debugger,,semi,,
+            debugger
+            // {prefix}-disable-next-line ,,no-debugger,,no-debugger,,
+            debugger
+            // {prefix}-disable-next-line ,  , ,,no-debugger, , ,
+        "
+            ),
+            format!("
+                /* {prefix}-disable , ,no-debugger, , */
+                debugger;
+            ")
         ];
 
         let fail = vec![
@@ -470,6 +548,68 @@ fn test() {
                 debugger;
             "
             ),
+            // Handles no spaces in comment
+            format!(
+                "
+            /*{prefix}-disable*/
+                debugger;
+            /*{prefix}-enable*/
+                debugger;
+            "
+            ),
+            format!(
+                "
+            /*{prefix}-disable no-debugger,no-console*/
+                debugger;
+            /*{prefix}-enable no-debugger,no-console*/
+                debugger;
+            "
+            ),
+            format!(
+                "debugger; //{prefix}-disable-line no-alert,quotes,semi
+            //{prefix}-disable-next-line no-alert,quotes,semi
+            debugger;
+            debugger; /*{prefix}-disable-line no-alert,quotes,semi */
+            /*{prefix}-disable-next-line no-alert,quotes,semi */
+            debugger;
+            /*{prefix}-disable-next-line
+no-alert,
+quotes,
+semi*/
+            debugger;
+        "
+            ),
+            // Handles extra spaces in comment
+            format!(
+                "
+            /*   \t\t {prefix}-disable   \t\t*/
+                debugger;
+            /*   \t\t {prefix}-enable   \t\t*/
+                debugger;
+            "
+            ),
+            format!(
+                "
+            /*   \t\t {prefix}-disable    \t\t no-debugger,   \t\t no-console   \t\t */
+                debugger;
+            /*   \t\t {prefix}-enable    \t\t no-debugger,   \t\t no-console   \t\t */
+                debugger;
+            "
+            ),
+            format!(
+                "debugger; //   \t\t {prefix}-disable-line   \t\t  no-alert,   \t\t quotes,   \t\t semi   \t\t 
+            //   \t\t {prefix}-disable-next-line   \t\t  no-alert,   \t\t quotes,   \t\t semi
+            debugger;
+            debugger; /*   \t\t {prefix}-disable-line    \t\t no-alert,   \t\t quotes,   \t\t semi   \t\t  */
+            /*   \t\t {prefix}-disable-next-line   \t\t  no-alert,   \t\t quotes,   \t\t semi */
+            debugger;
+            /*  \t\t {prefix}-disable-next-line
+  \t\t no-alert,  \t\t 
+  \t\t quotes,  \t\t 
+  \t\t semi  \t\t */
+            debugger;
+        "
+            ),
         ];
 
         Tester::new("no-debugger", pass, fail).test();