From 66f404c2f379021092e9e2a33f0421d9933a5af3 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Mon, 24 Jun 2024 02:21:40 +0000 Subject: [PATCH] fix(ast): fix JSON serialization of `BindingPattern` (#3856) #3855 added a `span` field to `BindingPattern` but it's duplicate information from `BindingPatternKind`. `BindingPatternKind`'s `span` is already included in JS AST, so serde can skip the duplicate in `BindingPattern`. --- crates/oxc_ast/src/ast/js.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/oxc_ast/src/ast/js.rs b/crates/oxc_ast/src/ast/js.rs index 7899247fabaa4..775fdb5f63abf 100644 --- a/crates/oxc_ast/src/ast/js.rs +++ b/crates/oxc_ast/src/ast/js.rs @@ -1326,7 +1326,7 @@ pub struct DebuggerStatement { #[cfg_attr(feature = "serialize", derive(Serialize, Tsify))] #[cfg_attr(feature = "serialize", serde(rename_all = "camelCase"))] pub struct BindingPattern<'a> { - #[cfg_attr(feature = "serialize", serde(flatten))] + #[cfg_attr(feature = "serialize", serde(skip))] pub span: Span, // serde(flatten) the attributes because estree has no `BindingPattern` #[cfg_attr(feature = "serialize", serde(flatten))]