From 0fbecdcd81546d3dc8ab30c652baa53e6dbbb3cb Mon Sep 17 00:00:00 2001 From: Dunqing <29533304+Dunqing@users.noreply.github.com> Date: Mon, 17 Jun 2024 16:47:02 +0000 Subject: [PATCH] fix(isolated-declarations): should be added to references, not bindings (#3726) --- crates/oxc_isolated_declarations/src/scope.rs | 4 ++-- tasks/coverage/transpile.snap | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/oxc_isolated_declarations/src/scope.rs b/crates/oxc_isolated_declarations/src/scope.rs index f82e1e122f716..72d8e1785b6a8 100644 --- a/crates/oxc_isolated_declarations/src/scope.rs +++ b/crates/oxc_isolated_declarations/src/scope.rs @@ -133,8 +133,8 @@ impl<'a> Visit<'a> for ScopeTree<'a> { fn visit_export_default_declaration(&mut self, decl: &ExportDefaultDeclaration<'a>) { if let ExportDefaultDeclarationKind::Identifier(ident) = &decl.declaration { - self.add_type_binding(&ident.name); - self.add_value_binding(&ident.name); + self.add_type_reference(&ident.name); + self.add_value_reference(&ident.name); } else { walk_export_default_declaration(self, decl); } diff --git a/tasks/coverage/transpile.snap b/tasks/coverage/transpile.snap index abf6b7bd7c909..244456ba8a41f 100644 --- a/tasks/coverage/transpile.snap +++ b/tasks/coverage/transpile.snap @@ -2,7 +2,7 @@ commit: d8086f14 transpile Summary: AST Parsed : 20/20 (100.00%) -Positive Passed: 8/20 (40.00%) +Positive Passed: 9/20 (45.00%) Mismatch: "declarationAsyncAndGeneratorFunctions.ts" Mismatch: "declarationBasicSyntax.ts" Mismatch: "declarationComputedPropertyNames.ts" @@ -14,4 +14,3 @@ Mismatch: "declarationPartialNodeReuseTypeOf.ts" Mismatch: "declarationRestParameters.ts" Mismatch: "declarationSingleFileHasErrors.ts" Mismatch: "declarationSingleFileHasErrorsReported.ts" -Mismatch: "declarationsSimple.ts"