From c5c72102e0635f4222d5748d79dfd27c32c41496 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Wed, 25 Mar 2026 17:34:44 +0000 Subject: [PATCH] refactor(parser): remove `Modifier::is_static()` (#20736) Refactor. Remove `Modifier::is_static` method. It's very simple logic and only used in one place, so just inline it into its one call site. --- crates/oxc_parser/src/modifiers.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/crates/oxc_parser/src/modifiers.rs b/crates/oxc_parser/src/modifiers.rs index c775e1b56ba28..a1a6a94b50b9f 100644 --- a/crates/oxc_parser/src/modifiers.rs +++ b/crates/oxc_parser/src/modifiers.rs @@ -119,11 +119,6 @@ impl Modifier { pub fn new(span: Span, kind: ModifierKind) -> Self { Self { span, kind } } - - #[inline] - pub fn is_static(&self) -> bool { - matches!(self.kind, ModifierKind::Static) - } } /// Symbol modifiers. Primarily used in TypeScript code, but some are also used @@ -370,7 +365,7 @@ impl<'a, C: Config> ParserImpl<'a, C> { permit_const_as_modifier, stop_on_start_of_class_static_block, ) { - if modifier.is_static() { + if modifier.kind == ModifierKind::Static { has_seen_static_modifier = true; } self.check_modifier(modifier_flags, &modifier);