From 89946e174c967ab894bbc10f947a75b58f5e800b Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Fri, 20 Mar 2026 22:15:56 +0000
Subject: [PATCH] perf(ast): mark `AstKind::address` as `#[inline]` (#20586)

Similar to #20585. As `AstKind`'s variants are all structs (no enums any more), and all structs have an `AstKind`, `AstKind::address` method boils down to a no-op. So mark it `#[inline]`.

Also remove some defunct code from `AstKind` codegen which was handling when an `AstKind` refers to an enum. This circumstance is no longer possible, so remove this code.
---
 crates/oxc_ast/src/generated/ast_kind.rs   |  4 ++++
 tasks/ast_tools/src/generators/ast_kind.rs | 15 ++++++---------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/crates/oxc_ast/src/generated/ast_kind.rs b/crates/oxc_ast/src/generated/ast_kind.rs
index d3a14a251cbbd..3435d643fe71b 100644
--- a/crates/oxc_ast/src/generated/ast_kind.rs
+++ b/crates/oxc_ast/src/generated/ast_kind.rs
@@ -1020,6 +1020,10 @@ impl GetSpan for AstKind<'_> {
 }
 
 impl GetAddress for AstKind<'_> {
+    /// Get [`Address`] of an [`AstKind`].
+    // This boils down to 1 instruction.
+    // In all cases, it gets the pointer from the reference in the `AstKind`.
+    #[inline]
     fn address(&self) -> Address {
         match *self {
             Self::Program(it) => it.unstable_address(),
diff --git a/tasks/ast_tools/src/generators/ast_kind.rs b/tasks/ast_tools/src/generators/ast_kind.rs
index fb549f67cceca..105c6ddb86314 100644
--- a/tasks/ast_tools/src/generators/ast_kind.rs
+++ b/tasks/ast_tools/src/generators/ast_kind.rs
@@ -84,7 +84,6 @@ impl Generator for AstKindGenerator {
         for type_def in &schema.types {
             let has_kind = match type_def {
                 TypeDef::Struct(struct_def) => struct_def.kind.has_kind,
-                TypeDef::Enum(enum_def) => enum_def.kind.has_kind,
                 _ => false,
             };
             if !has_kind {
@@ -101,12 +100,7 @@ impl Generator for AstKindGenerator {
 
             span_match_arms.extend(quote!( Self::#type_ident(it) => it.span(), ));
 
-            let get_address = match type_def {
-                TypeDef::Struct(_) => quote!(it.unstable_address()),
-                TypeDef::Enum(_) => quote!(it.address()),
-                _ => unreachable!(),
-            };
-            address_match_arms.extend(quote!( Self::#type_ident(it) => #get_address, ));
+            address_match_arms.extend(quote!( Self::#type_ident(it) => it.unstable_address(), ));
 
             let set_node_id = match type_def {
                 TypeDef::Struct(struct_def)
@@ -224,8 +218,11 @@ impl Generator for AstKindGenerator {
 
             ///@@line_break
             impl GetAddress for AstKind<'_> {
-                // TODO: Once only structs have `AstKind`s (https://github.com/oxc-project/oxc/issues/11490),
-                // mark this method `#[inline]`, because then it'll be boiled down to a single instruction.
+                ///@@line_break
+                /// Get [`Address`] of an [`AstKind`].
+                ///@ This boils down to 1 instruction.
+                ///@ In all cases, it gets the pointer from the reference in the `AstKind`.
+                #[inline]
                 fn address(&self) -> Address {
                     match *self {
                         #address_match_arms