From 7419dfb5787651da1c62e4525dbdac993311e308 Mon Sep 17 00:00:00 2001
From: camc314 <18101008+camc314@users.noreply.github.com>
Date: Mon, 2 Feb 2026 00:30:09 +0000
Subject: [PATCH] fix(linter): remove invalid debug assersion, add test
 (#18819)

debug asserion could fail if the json was not a valid oxlintrc
---
 apps/oxlint/src/js_config.rs                       |  1 -
 .../files/oxlint.config.ts                         |  5 +++++
 .../js_config_invalid_property/files/test.js       |  1 +
 .../js_config_invalid_property/output.snap.md      | 14 ++++++++++++++
 4 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 apps/oxlint/test/fixtures/js_config_invalid_property/files/oxlint.config.ts
 create mode 100644 apps/oxlint/test/fixtures/js_config_invalid_property/files/test.js
 create mode 100644 apps/oxlint/test/fixtures/js_config_invalid_property/output.snap.md

diff --git a/apps/oxlint/src/js_config.rs b/apps/oxlint/src/js_config.rs
index b40cb857af2f1..5aa63ba1f8ae8 100644
--- a/apps/oxlint/src/js_config.rs
+++ b/apps/oxlint/src/js_config.rs
@@ -84,7 +84,6 @@ fn parse_js_config_response(json: &str) -> Result<Vec<JsConfigResult>, Vec<OxcDi
                     let mut oxlintrc: Oxlintrc = match serde_json::from_value(entry.config) {
                         Ok(config) => config,
                         Err(err) => {
-                            debug_assert!(false, "All JS configs should be valid JSON");
                             errors.push(
                                 OxcDiagnostic::error(format!(
                                     "Failed to parse config from {}",
diff --git a/apps/oxlint/test/fixtures/js_config_invalid_property/files/oxlint.config.ts b/apps/oxlint/test/fixtures/js_config_invalid_property/files/oxlint.config.ts
new file mode 100644
index 0000000000000..7dbd381074ae9
--- /dev/null
+++ b/apps/oxlint/test/fixtures/js_config_invalid_property/files/oxlint.config.ts
@@ -0,0 +1,5 @@
+import { defineConfig } from "#oxlint";
+
+export default defineConfig({
+  rules: [],
+});
diff --git a/apps/oxlint/test/fixtures/js_config_invalid_property/files/test.js b/apps/oxlint/test/fixtures/js_config_invalid_property/files/test.js
new file mode 100644
index 0000000000000..d914c6066c433
--- /dev/null
+++ b/apps/oxlint/test/fixtures/js_config_invalid_property/files/test.js
@@ -0,0 +1 @@
+console.log("hi");
diff --git a/apps/oxlint/test/fixtures/js_config_invalid_property/output.snap.md b/apps/oxlint/test/fixtures/js_config_invalid_property/output.snap.md
new file mode 100644
index 0000000000000..9f542100b7e74
--- /dev/null
+++ b/apps/oxlint/test/fixtures/js_config_invalid_property/output.snap.md
@@ -0,0 +1,14 @@
+# Exit code
+1
+
+# stdout
+```
+Failed to parse oxlint configuration file.
+
+  x Failed to parse config from <fixture>/files/oxlint.config.ts
+  note: invalid type: sequence, expected Record<string, SeverityConf | [SeverityConf, ...any[]]>
+```
+
+# stderr
+```
+```