From 1aa75915a3066d6d6b99c06a998d4a5e77a5c96d Mon Sep 17 00:00:00 2001 From: Dunqing <29533304+Dunqing@users.noreply.github.com> Date: Tue, 6 Jan 2026 08:34:14 +0000 Subject: [PATCH] refactor(formatter): remove unnecessary clone for FormatContext and all its fields (#17697) Clone trait is unnecessary, so remove it. --- crates/oxc_formatter/src/external_formatter.rs | 2 +- crates/oxc_formatter/src/formatter/context.rs | 1 - crates/oxc_formatter/src/formatter/mod.rs | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/oxc_formatter/src/external_formatter.rs b/crates/oxc_formatter/src/external_formatter.rs index b313d7494f6f8..abd00f9dfe21e 100644 --- a/crates/oxc_formatter/src/external_formatter.rs +++ b/crates/oxc_formatter/src/external_formatter.rs @@ -17,7 +17,7 @@ const SUPPORTED_TAGS: &[&str] = &["css", "styled", "gql", "graphql", "html", "md /// This struct holds all callbacks that delegate to external (typically JS) implementations: /// - Embedded language formatting (CSS, GraphQL, HTML in template literals) /// - Tailwind CSS class sorting -#[derive(Clone, Default)] +#[derive(Default)] pub struct ExternalCallbacks { embedded_formatter: Option, tailwind: Option, diff --git a/crates/oxc_formatter/src/formatter/context.rs b/crates/oxc_formatter/src/formatter/context.rs index 12fc94e636257..63e8249636b59 100644 --- a/crates/oxc_formatter/src/formatter/context.rs +++ b/crates/oxc_formatter/src/formatter/context.rs @@ -84,7 +84,6 @@ impl TailwindContextEntry { } /// Context object storing data relevant when formatting an object. -#[derive(Clone)] pub struct FormatContext<'ast> { options: FormatOptions, diff --git a/crates/oxc_formatter/src/formatter/mod.rs b/crates/oxc_formatter/src/formatter/mod.rs index cb424c7b57421..8ded921aca412 100644 --- a/crates/oxc_formatter/src/formatter/mod.rs +++ b/crates/oxc_formatter/src/formatter/mod.rs @@ -56,7 +56,7 @@ pub use self::{ }; use self::{format_element::document::Document, group_id::UniqueGroupIdBuilder, prelude::TagKind}; -#[derive(Debug, Clone)] +#[derive(Debug)] pub struct Formatted<'a> { document: Document<'a>, context: FormatContext<'a>,