From 790beebd17b6f50bb74cb7f5536a1ca93e03cfdd Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Wed, 3 Dec 2025 14:47:24 +0000 Subject: [PATCH] perf(napi/parser): do not remove extraneous options on JS side (#16447) Similar to #16442. There's no need to remove the `experimental*` properties from `options` object on JS side. They'll be ignored by NAPI-RS on Rust side anyway, so creating a new object on JS side is pointless overhead. --- napi/parser/src-js/raw-transfer/eager.js | 4 ---- napi/parser/src-js/raw-transfer/lazy.js | 4 ---- 2 files changed, 8 deletions(-) diff --git a/napi/parser/src-js/raw-transfer/eager.js b/napi/parser/src-js/raw-transfer/eager.js index c38bfaf829ad7..5691b77dbdf6b 100644 --- a/napi/parser/src-js/raw-transfer/eager.js +++ b/napi/parser/src-js/raw-transfer/eager.js @@ -12,8 +12,6 @@ const require = createRequire(import.meta.url); * @returns {Object} - Object with property getters for `program`, `module`, `comments`, and `errors` */ export function parseSyncRaw(filename, sourceText, options) { - let _; - ({ experimentalRawTransfer: _, ...options } = options); return parseSyncRawImpl(filename, sourceText, options, deserialize); } @@ -36,8 +34,6 @@ export function parseSyncRaw(filename, sourceText, options) { * @returns {Object} - Object with property getters for `program`, `module`, `comments`, and `errors` */ export function parse(filename, sourceText, options) { - let _; - ({ experimentalRawTransfer: _, ...options } = options); return parseAsyncRawImpl(filename, sourceText, options, deserialize); } diff --git a/napi/parser/src-js/raw-transfer/lazy.js b/napi/parser/src-js/raw-transfer/lazy.js index cb5f73fcefc4c..12d6b563d4004 100644 --- a/napi/parser/src-js/raw-transfer/lazy.js +++ b/napi/parser/src-js/raw-transfer/lazy.js @@ -30,8 +30,6 @@ export { Visitor } from "./visitor.js"; * and `dispose` and `visit` methods */ export function parseSyncLazy(filename, sourceText, options) { - let _; - ({ experimentalLazy: _, ...options } = options); return parseSyncRawImpl(filename, sourceText, options, construct); } @@ -63,8 +61,6 @@ export function parseSyncLazy(filename, sourceText, options) { * and `dispose` and `visit` methods */ export function parse(filename, sourceText, options) { - let _; - ({ experimentalLazy: _, ...options } = options); return parseAsyncRawImpl(filename, sourceText, options, construct); }