-
-
Notifications
You must be signed in to change notification settings - Fork 708
docs(linter): Add configuration option docs for 4 rules. #15197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds JSON schema configuration support to four linter rules by adding JsonSchema derives and moving option documentation from the rule description to struct field documentation.
- Added
JsonSchemaderive andserdeattributes to configuration structs - Moved configuration documentation from
declare_oxc_lint!macro to struct field doc comments - Added
configparameter todeclare_oxc_lint!macro calls
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/oxc_linter/src/rules/typescript/no_require_imports.rs | Added JsonSchema support and moved allow and allow_as_import option docs to struct fields |
| crates/oxc_linter/src/rules/eslint/max_lines.rs | Added JsonSchema support and field documentation for max, skip_blank_lines, and skip_comments |
| crates/oxc_linter/src/rules/eslint/grouped_accessor_pairs.rs | Added JsonSchema, Serialize, and Deserialize derives with field documentation for accessor pair ordering |
| crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs | Added JsonSchema, Serialize, and Deserialize derives with field documentation for class method configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #15197 will not alter performanceComparing Summary
Footnotes
|
Part of #14743.
Generated docs: