From 32a41cfab57f9f216fee8ad76320b7987768898a Mon Sep 17 00:00:00 2001 From: Boshen <1430279+Boshen@users.noreply.github.com> Date: Wed, 15 Oct 2025 02:31:18 +0000 Subject: [PATCH] fix(napi/minify): s/passes/max_iterations to avoid confusion (#14608) `max_iterations` does not behave like `passes`, and may change in the future. It should only be used for debugging purposes, as said on the comment. --- napi/minify/index.d.ts | 2 +- napi/minify/src/options.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/napi/minify/index.d.ts b/napi/minify/index.d.ts index 096f96ae7f09a..64d4ced0da145 100644 --- a/napi/minify/index.d.ts +++ b/napi/minify/index.d.ts @@ -61,7 +61,7 @@ export interface CompressOptions { */ sequences?: boolean /** Limit the maximum number of iterations for debugging purpose. */ - passes?: number + maxIterations?: number } export interface CompressOptionsKeepNames { diff --git a/napi/minify/src/options.rs b/napi/minify/src/options.rs index b460eec8323e8..e5d9796563809 100644 --- a/napi/minify/src/options.rs +++ b/napi/minify/src/options.rs @@ -53,7 +53,7 @@ pub struct CompressOptions { pub sequences: Option, /// Limit the maximum number of iterations for debugging purpose. - pub passes: Option, + pub max_iterations: Option, } impl TryFrom<&CompressOptions> for oxc_minifier::CompressOptions { @@ -81,7 +81,7 @@ impl TryFrom<&CompressOptions> for oxc_minifier::CompressOptions { }, keep_names: o.keep_names.as_ref().map(Into::into).unwrap_or_default(), treeshake: TreeShakeOptions::default(), - max_iterations: o.passes, + max_iterations: o.max_iterations, }) } }