From 2e57351a09e621f65c555898f7c29a019f7757fe Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Thu, 2 Oct 2025 13:39:47 +0000
Subject: [PATCH] perf(linter/plugins): initialize `lineStartOffsets` as `[0]`
 (#14302)

Tiny perf optimization. `lineStartOffsets` always starts with `0` as first element. So initialize the array with that 1 initial empty, and never remove it. This avoids a redundant `push` when calculating line breaks in `initLines`.
---
 apps/oxlint/src-js/plugins/source_code.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/apps/oxlint/src-js/plugins/source_code.ts b/apps/oxlint/src-js/plugins/source_code.ts
index 7941924f31375..6ea15cc80c779 100644
--- a/apps/oxlint/src-js/plugins/source_code.ts
+++ b/apps/oxlint/src-js/plugins/source_code.ts
@@ -35,8 +35,9 @@ let sourceByteLen: number = 0;
 let ast: Program | null = null;
 
 // Lazily populated when `SOURCE_CODE.lines` is accessed.
+// `lineStartOffsets` starts as `[0]`, and `resetSource` doesn't remove that initial element, so it's never empty.
 const lines: string[] = [],
-  lineStartOffsets: number[] = [];
+  lineStartOffsets: number[] = [0];
 
 // Lazily populated when `SOURCE_CODE.visitorKeys` is accessed.
 let visitorKeys: { [key: string]: string[] } | null = null;
@@ -101,7 +102,7 @@ function initLines(): void {
    * and uses match.index to get the correct line start indices.
    */
 
-  lineStartOffsets.push(0);
+  // Note: `lineStartOffsets` starts as `[0]`
   let lastOffset = 0, offset, match;
   while ((match = LINE_BREAK_PATTERN.exec(sourceText))) {
     offset = match.index;
@@ -126,7 +127,7 @@ export function resetSource(): void {
   sourceText = null;
   ast = null;
   lines.length = 0;
-  lineStartOffsets.length = 0;
+  lineStartOffsets.length = 1;
 }
 
 // `SourceCode` object.