From 39fc0d65ab2f0547ac7b672e0a33b8a48a69d650 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Sun, 31 Aug 2025 05:27:03 +0000
Subject: [PATCH] perf(codegen): use `isize` for quote counters (#13441)

Small perf optimization for codegen when running in WASM. Use `isize` instead of `i64` for quote cost counters. `isize` is sufficient to prevent overflow, and is a single "word" in 32-bit WASM.
---
 crates/oxc_codegen/src/str.rs | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/crates/oxc_codegen/src/str.rs b/crates/oxc_codegen/src/str.rs
index 061eec0a79f3b..a8302459c29da 100644
--- a/crates/oxc_codegen/src/str.rs
+++ b/crates/oxc_codegen/src/str.rs
@@ -223,10 +223,13 @@ impl PrintStringState<'_> {
 
     /// Calculate optimum quote character to use, when backtick (`) is an option.
     fn calculate_quote_maybe_backtick(&self) -> Quote {
-        // String length is max `u32::MAX`, so use `i64` to make overflow impossible
-        let mut single_cost: i64 = 0;
-        let mut double_cost: i64 = 0;
-        let mut backtick_cost: i64 = 0;
+        // Max string length is:
+        // * 64-bit platforms: `u32::MAX`.
+        // * 32-bit platforms: `i32::MAX`.
+        // In either case, `isize` is sufficient to make overflow impossible.
+        let mut single_cost: isize = 0;
+        let mut double_cost: isize = 0;
+        let mut backtick_cost: isize = 0;
         let mut bytes = self.bytes.clone();
         while let Some(b) = bytes.next() {
             match b {
@@ -264,8 +267,11 @@ impl PrintStringState<'_> {
 
     /// Calculate optimum quote character to use, when backtick (`) is not an option.
     fn calculate_quote_no_backtick(&self) -> Quote {
-        // String length is max `u32::MAX`, so `i64` cannot overflow
-        let mut single_cost: i64 = 0;
+        // Max string length is:
+        // * 64-bit platforms: `u32::MAX`.
+        // * 32-bit platforms: `i32::MAX`.
+        // In either case, `isize` is sufficient to make overflow impossible.
+        let mut single_cost: isize = 0;
         for &b in self.bytes.clone() {
             match b {
                 b'\'' => single_cost += 1,