From cdf6b57faccd9b9e69db0865d72a1437de27a574 Mon Sep 17 00:00:00 2001
From: Sysix <sysix@sysix-coding.de>
Date: Sat, 26 Jul 2025 16:58:10 +0200
Subject: [PATCH] refactor(linter): add `setup` detection for vue files

---
 crates/oxc_linter/src/context/host.rs         |  6 ++++-
 crates/oxc_linter/src/context/mod.rs          |  5 +++++
 crates/oxc_linter/src/frameworks.rs           |  6 +++++
 crates/oxc_linter/src/lib.rs                  | 13 ++++++++---
 .../src/loader/partial_loader/astro.rs        |  5 +++--
 .../src/loader/partial_loader/svelte.rs       |  9 ++++++--
 .../src/loader/partial_loader/vue.rs          | 15 ++++++++++++-
 crates/oxc_linter/src/loader/source.rs        | 22 ++++++++++++++++---
 crates/oxc_linter/src/service/runtime.rs      |  9 ++++++--
 crates/oxc_linter/src/utils/jest.rs           |  3 ++-
 napi/playground/src/lib.rs                    | 12 +++++++---
 tasks/benchmark/benches/linter.rs             | 12 +++++++---
 12 files changed, 96 insertions(+), 21 deletions(-)

diff --git a/crates/oxc_linter/src/context/host.rs b/crates/oxc_linter/src/context/host.rs
index fb633acb82a00..7526af8116dd5 100644
--- a/crates/oxc_linter/src/context/host.rs
+++ b/crates/oxc_linter/src/context/host.rs
@@ -9,7 +9,7 @@ use crate::{
     config::LintConfig,
     disable_directives::{DisableDirectives, DisableDirectivesBuilder, RuleCommentType},
     fixer::{Fix, FixKind, Message, PossibleFixes},
-    frameworks,
+    frameworks::{self, FrameworkOptions},
     module_record::ModuleRecord,
     options::LintOptions,
     rules::RuleEnum,
@@ -63,6 +63,8 @@ pub struct ContextHost<'a> {
     pub(super) config: Arc<LintConfig>,
     /// Front-end frameworks that might be in use in the target file.
     pub(super) frameworks: FrameworkFlags,
+    // Specific framework options, for example, whether the context is inside `<script setup>` in Vue files.
+    pub(super) frameworks_options: FrameworkOptions,
 }
 
 impl<'a> ContextHost<'a> {
@@ -74,6 +76,7 @@ impl<'a> ContextHost<'a> {
         module_record: Arc<ModuleRecord>,
         options: LintOptions,
         config: Arc<LintConfig>,
+        frameworks_options: FrameworkOptions,
     ) -> Self {
         const DIAGNOSTICS_INITIAL_CAPACITY: usize = 512;
 
@@ -98,6 +101,7 @@ impl<'a> ContextHost<'a> {
             file_path,
             config,
             frameworks: options.framework_hints,
+            frameworks_options,
         }
         .sniff_for_frameworks()
     }
diff --git a/crates/oxc_linter/src/context/mod.rs b/crates/oxc_linter/src/context/mod.rs
index 876d957d170b5..590ccfdec7545 100644
--- a/crates/oxc_linter/src/context/mod.rs
+++ b/crates/oxc_linter/src/context/mod.rs
@@ -17,6 +17,7 @@ use crate::{
     config::GlobalValue,
     disable_directives::DisableDirectives,
     fixer::{Fix, FixKind, Message, PossibleFixes, RuleFix, RuleFixer},
+    frameworks::FrameworkOptions,
 };
 
 mod host;
@@ -114,6 +115,10 @@ impl<'a> LintContext<'a> {
         self.parent.module_record()
     }
 
+    pub fn frameworks_options(&self) -> &FrameworkOptions {
+        &self.parent.frameworks_options
+    }
+
     /// Get the control flow graph for the current program.
     #[inline]
     pub fn cfg(&self) -> &ControlFlowGraph {
diff --git a/crates/oxc_linter/src/frameworks.rs b/crates/oxc_linter/src/frameworks.rs
index 1fcba314becaa..3f76ae07ffed6 100644
--- a/crates/oxc_linter/src/frameworks.rs
+++ b/crates/oxc_linter/src/frameworks.rs
@@ -95,3 +95,9 @@ pub fn has_vitest_imports(module_record: &ModuleRecord) -> bool {
 pub fn has_jest_imports(module_record: &ModuleRecord) -> bool {
     module_record.import_entries.iter().any(|entry| entry.module_request.name() == "@jest/globals")
 }
+
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
+pub enum FrameworkOptions {
+    None,     // default
+    VueSetup, // context is inside `<script setup>`
+}
diff --git a/crates/oxc_linter/src/lib.rs b/crates/oxc_linter/src/lib.rs
index 427abf5c7286d..995f1983cfb30 100644
--- a/crates/oxc_linter/src/lib.rs
+++ b/crates/oxc_linter/src/lib.rs
@@ -50,7 +50,7 @@ pub use crate::{
     },
     external_plugin_store::{ExternalPluginStore, ExternalRuleId},
     fixer::FixKind,
-    frameworks::FrameworkFlags,
+    frameworks::{FrameworkFlags, FrameworkOptions},
     loader::LINTABLE_EXTENSIONS,
     module_record::ModuleRecord,
     options::LintOptions,
@@ -127,12 +127,19 @@ impl Linter {
         path: &Path,
         semantic: Rc<Semantic<'a>>,
         module_record: Arc<ModuleRecord>,
+        framework_options: FrameworkOptions,
         allocator: &Allocator,
     ) -> Vec<Message<'a>> {
         let ResolvedLinterState { rules, config, external_rules } = self.config.resolve(path);
 
-        let ctx_host =
-            Rc::new(ContextHost::new(path, semantic, module_record, self.options, config));
+        let ctx_host = Rc::new(ContextHost::new(
+            path,
+            semantic,
+            module_record,
+            self.options,
+            config,
+            framework_options,
+        ));
 
         let rules = rules
             .iter()
diff --git a/crates/oxc_linter/src/loader/partial_loader/astro.rs b/crates/oxc_linter/src/loader/partial_loader/astro.rs
index 7a92cc5b7c373..4e624a3e78b83 100644
--- a/crates/oxc_linter/src/loader/partial_loader/astro.rs
+++ b/crates/oxc_linter/src/loader/partial_loader/astro.rs
@@ -2,7 +2,7 @@ use memchr::memmem::Finder;
 
 use oxc_span::{SourceType, Span};
 
-use crate::loader::JavaScriptSource;
+use crate::{frameworks::FrameworkOptions, loader::JavaScriptSource};
 
 use super::{SCRIPT_END, SCRIPT_START};
 
@@ -47,7 +47,7 @@ impl<'a> AstroPartialLoader<'a> {
         // move start to the end of the ASTRO_SPLIT
         let start = start + ASTRO_SPLIT.len() as u32;
         let js_code = Span::new(start, end).source_text(self.source_text);
-        Some(JavaScriptSource::partial(js_code, SourceType::ts(), start))
+        Some(JavaScriptSource::partial(js_code, SourceType::ts(), FrameworkOptions::None, start))
     }
 
     /// In .astro files, you can add client-side JavaScript by adding one (or more) `<script>` tags.
@@ -94,6 +94,7 @@ impl<'a> AstroPartialLoader<'a> {
             results.push(JavaScriptSource::partial(
                 &self.source_text[js_start..js_end],
                 SourceType::ts(),
+                FrameworkOptions::None,
                 js_start as u32,
             ));
         }
diff --git a/crates/oxc_linter/src/loader/partial_loader/svelte.rs b/crates/oxc_linter/src/loader/partial_loader/svelte.rs
index a821a46099ea6..18e030e280037 100644
--- a/crates/oxc_linter/src/loader/partial_loader/svelte.rs
+++ b/crates/oxc_linter/src/loader/partial_loader/svelte.rs
@@ -2,7 +2,7 @@ use memchr::memmem::Finder;
 
 use oxc_span::SourceType;
 
-use crate::loader::JavaScriptSource;
+use crate::{frameworks::FrameworkOptions, loader::JavaScriptSource};
 
 use super::{SCRIPT_END, SCRIPT_START, find_script_closing_angle};
 
@@ -62,7 +62,12 @@ impl<'a> SveltePartialLoader<'a> {
 
         // NOTE: loader checked that source_text.len() is less than u32::MAX
         #[expect(clippy::cast_possible_truncation)]
-        Some(JavaScriptSource::partial(source_text, source_type, js_start as u32))
+        Some(JavaScriptSource::partial(
+            source_text,
+            source_type,
+            FrameworkOptions::None,
+            js_start as u32,
+        ))
     }
 }
 
diff --git a/crates/oxc_linter/src/loader/partial_loader/vue.rs b/crates/oxc_linter/src/loader/partial_loader/vue.rs
index 70caba8c0702e..079b2b72ed7e2 100644
--- a/crates/oxc_linter/src/loader/partial_loader/vue.rs
+++ b/crates/oxc_linter/src/loader/partial_loader/vue.rs
@@ -2,6 +2,8 @@ use memchr::memmem::Finder;
 
 use oxc_span::SourceType;
 
+use crate::frameworks::FrameworkOptions;
+
 use super::{JavaScriptSource, SCRIPT_END, SCRIPT_START, find_script_closing_angle};
 
 pub struct VuePartialLoader<'a> {
@@ -52,6 +54,7 @@ impl<'a> VuePartialLoader<'a> {
 
         // parse `lang`
         let lang = Self::extract_lang_attribute(content);
+        let is_setup = content.contains("setup"); // check if "setup" is present, does not check if its inside an attribute
 
         let Ok(mut source_type) = SourceType::from_extension(lang) else { return None };
         if !lang.contains('x') {
@@ -70,7 +73,12 @@ impl<'a> VuePartialLoader<'a> {
         let source_text = &self.source_text[js_start..js_end];
         // NOTE: loader checked that source_text.len() is less than u32::MAX
         #[expect(clippy::cast_possible_truncation)]
-        Some(JavaScriptSource::partial(source_text, source_type, js_start as u32))
+        Some(JavaScriptSource::partial(
+            source_text,
+            source_type,
+            if is_setup { FrameworkOptions::VueSetup } else { FrameworkOptions::None },
+            js_start as u32,
+        ))
     }
 
     fn extract_lang_attribute(content: &str) -> &str {
@@ -115,6 +123,8 @@ impl<'a> VuePartialLoader<'a> {
 mod test {
     use oxc_span::SourceType;
 
+    use crate::FrameworkOptions;
+
     use super::{JavaScriptSource, VuePartialLoader};
 
     fn parse_vue(source_text: &str) -> JavaScriptSource<'_> {
@@ -132,6 +142,7 @@ mod test {
         "#;
 
         let result = parse_vue(source_text);
+        assert_eq!(result.framework_options, FrameworkOptions::None);
         assert_eq!(result.source_text, r#" console.log("hi") "#);
     }
 
@@ -229,7 +240,9 @@ mod test {
         let sources = VuePartialLoader::new(source_text).parse();
         assert_eq!(sources.len(), 2);
         assert_eq!(sources[0].source_text, "a");
+        assert_eq!(sources[0].framework_options, FrameworkOptions::None);
         assert_eq!(sources[1].source_text, "b");
+        assert_eq!(sources[1].framework_options, FrameworkOptions::VueSetup);
     }
 
     #[test]
diff --git a/crates/oxc_linter/src/loader/source.rs b/crates/oxc_linter/src/loader/source.rs
index 8da3641c5ec35..5d9a246f27c67 100644
--- a/crates/oxc_linter/src/loader/source.rs
+++ b/crates/oxc_linter/src/loader/source.rs
@@ -1,5 +1,7 @@
 use oxc_span::SourceType;
 
+use crate::frameworks::FrameworkOptions;
+
 #[derive(Debug, Clone, Copy)]
 #[non_exhaustive]
 pub struct JavaScriptSource<'a> {
@@ -10,15 +12,29 @@ pub struct JavaScriptSource<'a> {
     pub start: u32,
     #[expect(dead_code)]
     is_partial: bool,
+
+    // some partial sources can have special options defined, like Vue's `<script setup>`.
+    pub framework_options: FrameworkOptions,
 }
 
 impl<'a> JavaScriptSource<'a> {
     pub fn new(source_text: &'a str, source_type: SourceType) -> Self {
-        Self { source_text, source_type, start: 0, is_partial: false }
+        Self {
+            source_text,
+            source_type,
+            start: 0,
+            is_partial: false,
+            framework_options: FrameworkOptions::None,
+        }
     }
 
-    pub fn partial(source_text: &'a str, source_type: SourceType, start: u32) -> Self {
-        Self { source_text, source_type, start, is_partial: true }
+    pub fn partial(
+        source_text: &'a str,
+        source_type: SourceType,
+        framework_options: FrameworkOptions,
+        start: u32,
+    ) -> Self {
+        Self { source_text, source_type, start, is_partial: true, framework_options }
     }
 
     pub fn as_str(&self) -> &'a str {
diff --git a/crates/oxc_linter/src/service/runtime.rs b/crates/oxc_linter/src/service/runtime.rs
index a0c17efaca7c0..b2ad1b0da83fe 100644
--- a/crates/oxc_linter/src/service/runtime.rs
+++ b/crates/oxc_linter/src/service/runtime.rs
@@ -25,6 +25,7 @@ use oxc_span::{CompactStr, SourceType, VALID_EXTENSIONS};
 use crate::{
     Fixer, Linter, Message,
     fixer::PossibleFixes,
+    frameworks::FrameworkOptions,
     loader::{JavaScriptSource, LINT_PARTIAL_LOADER_EXTENSIONS, PartialLoader},
     module_record::ModuleRecord,
     utils::read_to_arena_str,
@@ -524,6 +525,7 @@ impl Runtime {
                                 path,
                                 Rc::new(section.semantic.unwrap()),
                                 Arc::clone(&module_record),
+                                section.source.framework_options,
                                 allocator_guard,
                             ),
                             Err(errors) => errors
@@ -640,6 +642,7 @@ impl Runtime {
                                     Path::new(&module.path),
                                     Rc::new(section.semantic.unwrap()),
                                     Arc::clone(&module_record),
+                                    section.source.framework_options,
                                     allocator_guard,
                                 ),
                             };
@@ -763,6 +766,7 @@ impl Runtime {
                                         Path::new(&module.path),
                                         Rc::new(section.semantic.unwrap()),
                                         Arc::clone(&module_record),
+                                        section.source.framework_options,
                                         allocator_guard,
                                     ),
                                     Err(errors) => errors
@@ -893,8 +897,9 @@ impl Runtime {
         allocator: &'a Allocator,
         mut out_sections: Option<&mut SectionContents<'a>>,
     ) -> SmallVec<[Result<ResolvedModuleRecord, Vec<OxcDiagnostic>>; 1]> {
-        let section_sources = PartialLoader::parse(ext, source_text)
-            .unwrap_or_else(|| vec![JavaScriptSource::partial(source_text, source_type, 0)]);
+        let section_sources = PartialLoader::parse(ext, source_text).unwrap_or_else(|| {
+            vec![JavaScriptSource::partial(source_text, source_type, FrameworkOptions::None, 0)]
+        });
 
         let mut section_module_records = SmallVec::<
             [Result<ResolvedModuleRecord, Vec<OxcDiagnostic>>; 1],
diff --git a/crates/oxc_linter/src/utils/jest.rs b/crates/oxc_linter/src/utils/jest.rs
index b8c2d3a26926f..c05789214e921 100644
--- a/crates/oxc_linter/src/utils/jest.rs
+++ b/crates/oxc_linter/src/utils/jest.rs
@@ -311,7 +311,7 @@ mod test {
     use oxc_semantic::SemanticBuilder;
     use oxc_span::SourceType;
 
-    use crate::{ContextHost, ModuleRecord, options::LintOptions};
+    use crate::{ContextHost, ModuleRecord, frameworks::FrameworkOptions, options::LintOptions};
 
     #[test]
     fn test_is_jest_file() {
@@ -329,6 +329,7 @@ mod test {
                 Arc::new(ModuleRecord::default()),
                 LintOptions::default(),
                 Arc::default(),
+                FrameworkOptions::None,
             ))
             .spawn_for_test()
         };
diff --git a/napi/playground/src/lib.rs b/napi/playground/src/lib.rs
index f0396e40e1619..5405f5e49f33b 100644
--- a/napi/playground/src/lib.rs
+++ b/napi/playground/src/lib.rs
@@ -30,8 +30,8 @@ use oxc::{
 use oxc_formatter::{FormatOptions, Formatter};
 use oxc_index::Idx;
 use oxc_linter::{
-    ConfigStore, ConfigStoreBuilder, ExternalPluginStore, LintOptions, Linter, ModuleRecord,
-    Oxlintrc,
+    ConfigStore, ConfigStoreBuilder, ExternalPluginStore, FrameworkOptions, LintOptions, Linter,
+    ModuleRecord, Oxlintrc,
 };
 use oxc_napi::{Comment, OxcError, convert_utf8_to_utf16};
 
@@ -315,7 +315,13 @@ impl Oxc {
                 ConfigStore::new(lint_config, FxHashMap::default(), ExternalPluginStore::default()),
                 None,
             )
-            .run(path, Rc::clone(&semantic), Arc::clone(module_record), allocator);
+            .run(
+                path,
+                Rc::clone(&semantic),
+                Arc::clone(module_record),
+                FrameworkOptions::None,
+                allocator,
+            );
             self.diagnostics.extend(linter_ret.into_iter().map(|e| e.error));
         }
     }
diff --git a/tasks/benchmark/benches/linter.rs b/tasks/benchmark/benches/linter.rs
index f5ce0d0b39d8e..426160164122e 100644
--- a/tasks/benchmark/benches/linter.rs
+++ b/tasks/benchmark/benches/linter.rs
@@ -5,8 +5,8 @@ use rustc_hash::FxHashMap;
 use oxc_allocator::Allocator;
 use oxc_benchmark::{BenchmarkId, Criterion, criterion_group, criterion_main};
 use oxc_linter::{
-    ConfigStore, ConfigStoreBuilder, ExternalPluginStore, FixKind, LintOptions, Linter,
-    ModuleRecord,
+    ConfigStore, ConfigStoreBuilder, ExternalPluginStore, FixKind, FrameworkOptions, LintOptions,
+    Linter, ModuleRecord,
 };
 use oxc_parser::Parser;
 use oxc_semantic::SemanticBuilder;
@@ -39,7 +39,13 @@ fn bench_linter(criterion: &mut Criterion) {
         .with_fix(FixKind::All);
         group.bench_function(id, |b| {
             b.iter(|| {
-                linter.run(path, Rc::clone(&semantic), Arc::clone(&module_record), &allocator)
+                linter.run(
+                    path,
+                    Rc::clone(&semantic),
+                    Arc::clone(&module_record),
+                    FrameworkOptions::None,
+                    &allocator,
+                )
             });
         });
     }