From 314f970bc2eca1f1ad43cfb7f01c21ab51b7c306 Mon Sep 17 00:00:00 2001 From: Boshen <1430279+Boshen@users.noreply.github.com> Date: Sat, 12 Jul 2025 03:05:45 +0000 Subject: [PATCH] feat(minifier): remove unused `-1n` (#12235) ref: https://github.com/evanw/esbuild/commit/f4159a7b823cd5fe2217da2c30e8873d2f319667 --- crates/oxc_minifier/src/peephole/remove_unused_expression.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/oxc_minifier/src/peephole/remove_unused_expression.rs b/crates/oxc_minifier/src/peephole/remove_unused_expression.rs index 338cd93261f45..a59bdce78fc67 100644 --- a/crates/oxc_minifier/src/peephole/remove_unused_expression.rs +++ b/crates/oxc_minifier/src/peephole/remove_unused_expression.rs @@ -58,7 +58,7 @@ impl<'a> PeepholeOptimizations { self.remove_unused_expression(e, state, ctx) } } - _ => false, + _ => !e.may_have_side_effects(ctx), } } @@ -768,6 +768,8 @@ mod test { test_same("delete x.y"); test_same("delete x.y.z()"); test_same("+0n"); // Uncaught TypeError: Cannot convert a BigInt value to a number + test("-0n", ""); + test("-1n", ""); } #[test]