From d32cb4babf07ac08568e5b3333d31ae959ea1b27 Mon Sep 17 00:00:00 2001 From: Sysix <3897725+Sysix@users.noreply.github.com> Date: Wed, 25 Jun 2025 18:26:26 +0000 Subject: [PATCH] fix(linter): fix default values for `eslint/no-redeclare` (#11911) --- crates/oxc_linter/src/rules/eslint/no_redeclare.rs | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/crates/oxc_linter/src/rules/eslint/no_redeclare.rs b/crates/oxc_linter/src/rules/eslint/no_redeclare.rs index d738fdba60c82..642f29d2641aa 100644 --- a/crates/oxc_linter/src/rules/eslint/no_redeclare.rs +++ b/crates/oxc_linter/src/rules/eslint/no_redeclare.rs @@ -22,11 +22,17 @@ fn no_redeclare_as_builtin_in_diagnostic(name: &str, span: Span) -> OxcDiagnosti .with_label(span) } -#[derive(Debug, Default, Clone)] +#[derive(Debug, Clone)] pub struct NoRedeclare { built_in_globals: bool, } +impl Default for NoRedeclare { + fn default() -> Self { + Self { built_in_globals: true } + } +} + declare_oxc_lint!( /// ### What it does /// @@ -131,6 +137,9 @@ impl Rule for NoRedeclare { fn test() { use crate::tester::Tester; + let defaults = NoRedeclare::default(); + assert!(defaults.built_in_globals); + let pass = vec![ ("var a = 3; var b = function() { var a = 10; };", None), ("var a = 3; a = 10;", None),