From 0c075834520ff3f0208fa07bc8bd2240cc45ffd8 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Fri, 4 Apr 2025 10:52:04 +0000 Subject: [PATCH] refactor(ast_tools): use `write_it!` macro (#10219) #10196 replaced inefficient pattern of `string.push_str(&format!("..."))` with `let _ = write!(string, "...");`. But in `oxc_ast_tools` we also have the `write_it!` macro for this - `write_it!(string, "...");`. Use it. --- tasks/ast_tools/src/generators/typescript.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tasks/ast_tools/src/generators/typescript.rs b/tasks/ast_tools/src/generators/typescript.rs index 33203d1f347e3..049800f2850eb 100644 --- a/tasks/ast_tools/src/generators/typescript.rs +++ b/tasks/ast_tools/src/generators/typescript.rs @@ -1,6 +1,6 @@ //! Generator for TypeScript type definitions for all AST types. -use std::{borrow::Cow, fmt::Write}; +use std::borrow::Cow; use itertools::Itertools; @@ -117,7 +117,7 @@ fn generate_ts_type_def_for_struct( if should_add_type_field_to_struct(struct_def) { let type_name = struct_def.estree.rename.as_deref().unwrap_or_else(|| struct_def.name()); - let _ = write!(fields_str, "\n\ttype: '{type_name}';"); + write_it!(fields_str, "\n\ttype: '{type_name}';"); } if !struct_def.estree.no_type { @@ -272,7 +272,7 @@ fn generate_ts_type_def_for_struct_field_impl<'s>( let field_camel_name = get_struct_field_name(field); let question_mark = if field.estree.is_ts { "?" } else { "" }; - let _ = write!(fields_str, "\n\t{field_camel_name}{question_mark}: {field_type_name};"); + write_it!(fields_str, "\n\t{field_camel_name}{question_mark}: {field_type_name};"); } /// Generate Typescript type definition for an extra struct field @@ -288,7 +288,7 @@ fn generate_ts_type_def_for_added_struct_field( panic!("No `ts_type` provided for ESTree converter `{converter_name}`"); }; let question_mark = if converter.estree.is_ts { "?" } else { "" }; - let _ = write!(fields_str, "\n\t{field_name}{question_mark}: {ts_type};"); + write_it!(fields_str, "\n\t{field_name}{question_mark}: {ts_type};"); } /// Get the TS type definition for a converter.