Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): typescript::isolated_declarations #207

Closed
Boshen opened this issue Mar 24, 2023 · 3 comments
Closed

feat(linter): typescript::isolated_declarations #207

Boshen opened this issue Mar 24, 2023 · 3 comments
Assignees
@YangchenYe323
Labels
E-Help Wanted Experience level - For the experienced collaborators good first issue Experience Level - Good for newcomers P-high Priority - High

Comments

@Boshen
Copy link
Member

Boshen commented Mar 24, 2023 •
edited
Loading

Reference: microsoft/TypeScript#53463

This project is really interesting. I'd like to show case how simple it is to implement a linter in Oxc and also demonstrate our speed.

To start with, we can potentially implement some of the rules for R1, R2, R3, R5 and R6.

I'll try and make a release on Sunday Monday so people can start playing with this on Monday.

I'll also have to implement -A all -D isolated_declarations.

Pinging @YangchenYe323 and @jason89521, are you interested on implementing some of these rules this weekend?
@Boshen Boshen added E-Help Wanted Experience level - For the experienced collaborators good first issue Experience Level - Good for newcomers P-high Priority - High labels Mar 24, 2023
@YangchenYe323
Copy link
Contributor

I'll take a look tomorrow. Are we going to implement all the restrictions in a single lint rule?

@YangchenYe323 YangchenYe323 self-assigned this Mar 25, 2023
@YangchenYe323 YangchenYe323 mentioned this issue Mar 25, 2023
Merged
@Boshen
Copy link
Member Author

Boshen commented Mar 25, 2023

Are we going to implement all the restrictions in a single lint rule?

Dumping everything in a single file isn't that bad I guess.

@Boshen Boshen mentioned this issue Mar 26, 2023
Closed
3 tasks
@Boshen
Copy link
Member Author

Boshen commented Mar 29, 2023

Closing for now, we can reopen if someone reaches us.

@Boshen Boshen closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YangchenYe323 YangchenYe323

Labels
E-Help Wanted Experience level - For the experienced collaborators good first issue Experience Level - Good for newcomers P-high Priority - High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Boshen @YangchenYe323