Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate remaining apiSharees/sharees.feature failing tests #2354

Closed
phil-davis opened this issue Aug 4, 2021 · 2 comments
Closed

Investigate remaining apiSharees/sharees.feature failing tests #2354

phil-davis opened this issue Aug 4, 2021 · 2 comments

Comments

@phil-davis
Copy link
Contributor

See cs3org/reva#1954

Many apiSharees/sharees.feature test scenarios are now passing - that is "a good thing". But there are others that are still failing, and the comment in the expected-failures file is: "These tests fail because they contain some configuration steps for oc10 specific configuration."

  • investigate exactly which test step is causing the failure
  • if possible, refactor the test scenario(s) so that they do not depend so much on oC10 specific configuration (but still keep them testing the same things!) or
  • raise issues (or find existing issues) to document what behavior is missing or wrong in OCIS, and add the issue references to the expected-failures file(s)

After doing this, we can decide, for each issue, if it is a feature/option that will be implemented in OCIS in the future (and leave the test running) or if the feature/option will not be supported then we can tag the scenarios "not to implement on OCIS"

@stale
Copy link

stale bot commented Oct 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Oct 10, 2021
@phil-davis
Copy link
Contributor Author

This was sorted out in owncloud/core#39096 and cs3org/reva#1954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants