Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Collaboration file extension check to case-insensitive comparison #10949

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fixed Collaboration file extension check to case-insensitive comparison #10949

merged 1 commit into from
Feb 3, 2025

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Jan 30, 2025

Description

Fixed Collaboration file extension check to case-insensitive comparison.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jvillafanez
Copy link
Member

In general, how are we handling the extensions? Are we considering them case-sensitive everywhere or not?
I know it's convenient to have a case-insensitive comparison, but I'd prefer to keep consistency as much as possible.

@2403905
Copy link
Contributor Author

2403905 commented Feb 3, 2025 •
edited
Loading

In general, how are we handling the extensions? Are we considering them case-sensitive everywhere or not? I know it's convenient to have a case-insensitive comparison, but I'd prefer to keep consistency as much as possible.

We do, we keep consistency. We use the case-insensitive when detect. https://github.com/cs3org/reva/blob/13914932642d9cbc88d436e254cb121f793362f8/pkg/mime/mime.go#L1170

@2403905 2403905 enabled auto-merge February 3, 2025 08:53
@2403905 2403905 merged commit e9bea99 into owncloud:master Feb 3, 2025
4 checks passed
ownclouders pushed a commit that referenced this pull request Feb 3, 2025
@2403905
Merge pull request #10949 from 2403905/issue-10947
45e6f1b 
Fixed Collaboration file extension check to case-insensitive comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@kobergj kobergj Awaiting requested review from kobergj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collaboration file extension check is case sensitive
2 participants
@2403905 @jvillafanez