[QA] tests for exceeding thumbnails max_input configs

[saw-jan]

Bug report: #10589

Required envs: (change values if necessary)

THUMBNAILS_MAX_INPUT_IMAGE_FILE_SIZE=1MB
THUMBNAILS_MAX_INPUT_WIDTH=100
THUMBNAILS_MAX_INPUT_HEIGHT=100

Test cases:

Pre-conditions:

• run ocis with above thumbnails configs

Test:

• Image

  • download the 32x32 thumbnail of image that doesn't exceed any configs (should be successful)
  • try to download 32x32 thumbnail of image that exceeds one of the config value
    • assert 403 Forbidden
    • assert response body

      <?xml version="1.0" encoding="UTF-8"?>
      <d:error xmlns:d="DAV" xmlns:s="http://sabredav.org/ns">
        <s:exception></s:exception>
        <s:message>thumbnails: image is too large</s:message>
       </d:error>

    Tests:
    • i have merged test with with dimension 36x36 because web uses 36x36 thumbnail [tests-only][full-ci] tests: adding test coverage for thumbnail service #10763

• Text
  NOTE: for text files, 640x480 res image will be created for thumbnail processing. See

  ocis/services/thumbnails/pkg/preprocessor/preprocessor.go

  Lines 110 to 111 in 8a522b9

  	func (t TxtToImageConverter) Convert(r io.Reader) (interface{}, error) {
  	img := image.NewRGBA(image.Rect(0, 0, 640, 480))

  • Set res configs to 700 and download 32x32 thumbnail (should be successful)
  • Set res configs to 200 and try to download 32x32 thumbnail (assert errors) [tests-only][full-ci] tests: adding test coverage for thumbnail service #10763

[nirajacharya2]

* [ ]  download the 32x32 thumbnail of that image

when i tested for dimentions 32x32 and 128x128 i get 200 response.

idk why its working for those dimentions.

@saw-jan

[nirajacharya2]

* [ ]  download the 32x32 thumbnail of that image

when i tested for dimentions 32x32 and 128x128 i get 200 response.

idk why its working for those dimentions.

@saw-jan

i don't get the above problem locally but it is still present in ci
https://drone.owncloud.com/owncloud/ocis/42180/60/5

```shell @issue-10589 @env-config

Scenario Outline: try to download an image preview when the maximum thumbnail input value in the environment is set to a small value # /drone/src/tests/acceptance/features/coreApiWebdavPreviews/previews.feature:372

Given the following configs have been set:                                                                                               # OcisConfigContext::theConfigHasBeenSetToValue()
  | config                               | value |
  | THUMBNAILS_MAX_INPUT_IMAGE_FILE_SIZE | 1KB   |
  | THUMBNAILS_MAX_INPUT_WIDTH           | 200   |
  | THUMBNAILS_MAX_INPUT_HEIGHT          | 200   |
And using <dav-path-version> DAV path                                                                                                    # FeatureContext::usingOldOrNewOrSpacesDavPath()

And user "Alice" has uploaded file "filesForUpload/testavatar.jpg" to "/testimage.jpg"                                                   # FeatureContext::userHasUploadedAFileTo()
When user "Alice" downloads the preview of "/testimage.jpg" with width "32" and height "32" and processor thumbnail using the WebDAV API # FeatureContext::userDownloadsThePreviewOfWithWidthHeightProcessorUsingWebDAVAPI()
Then the HTTP status code should be "403"                                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
And the value of the item "/d:error/s:message" in the response should be "thumbnails: image is too large"                                # WebDavPropertiesContext::assertValueOfItemInResponseIs()

Examples:
  | dav-path-version |
  | old              |
    Failed step: Then the HTTP status code should be "403"
    HTTP status code 200 is not the expected value 403
    Failed asserting that 200 matches expected '403'.
  | new              |
    Failed step: Then the HTTP status code should be "403"
    HTTP status code 200 is not the expected value 403
    Failed asserting that 200 matches expected '403'.
  | spaces           |
    Failed step: Then the HTTP status code should be "403"
    HTTP status code 200 is not the expected value 403
    Failed asserting that 200 matches expected '403'.

[saw-jan]

i have merged test with with dimension 36x36 because web uses 36x36 thumbnail

But you will actually get 64x64 res image not 36x36. but it is by design in ocis

[saw-jan]

The behavior is OK for image files. Trying to get thumbnail of an image exceeding any of THUMBNAILS_MAX_INPUT_* config returns 403

[saw-jan]

Same should be the behavior for text file as well. See the description above.

NOTE: for text files, 640x480 res image will be created for thumbnail processing

[saw-jan]

@nirajacharya2

i have merged test with with dimension 36x36 because web uses 36x36 thumbnail

Please, use 32 instead of 36 or use 64 if you want to follow web client

[saw-jan]

try to download the 200x200 (exceeding config value) thumbnail of that image

this statement is wrong. the requested res doesn't get affected by the configured max settings. Those settings are for the input image