Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide additional oc:filter options for clients #31572

Closed
SamuAlfageme opened this issue May 29, 2018 · 6 comments
Closed

Provide additional oc:filter options for clients #31572

SamuAlfageme opened this issue May 29, 2018 · 6 comments

Comments

@SamuAlfageme
Copy link

SamuAlfageme commented May 29, 2018

The iOS team is in the verge of implementing a file filtering feature on their new app: owncloud/ios-app#50 (comment) - while it has a "local filter" component on the client; there are some scenarios where the server filter is in place and desirable to be used. For @pablocarmu to use as a guide of what sort of filtering is available nowadays:

  • In black: standard WebDAV APIs (that can be used together with <oc:filters>)
  • In red: OCS' files_sharing APIs: (shares/remote_shares) +shared_with_me= query param
  • In blue: "hidden files" which uses a "private" /files/api/v1/showhidden endpoint

I guess "hidden files" filter could be easily implemented also server side (i.e. sending a filtered REPORT that returns the file list removing those). Not that sure if in the long term it makes sense to unify also those files_sharing APIs with the rest though (coupling concerns).

cc/ @DeepDiver1975 @PVince81

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #31362 (Server-side Encryption HELP), #15033 (Preventing some directories from being synced, server side), #25112 (webdav endpoints), #8863 (Filter "Shared by link" view on the server side), and #12195 (server not found).

@PVince81
Copy link
Contributor

files/api/v1/showhidden is likely only there to store the user's preference, it doesn't return any results

@PVince81
Copy link
Contributor

files_sharing aren't filters either because the nodes contained inside are more than just file nodes: they are share nodes with more information. Putting this on Webdav level would require to convert the OCS Share endpoints to Webdav.

@SamuAlfageme
Copy link
Author

@PVince81 :

files/api/v1/showhidden is likely only there to store the user's preference, it doesn't return any results

Indeed; maybe I should rename the issue to express a different idea.

Putting this on Webdav level would require to convert the OCS Share endpoints to Webdav.

That's exactly what I meant in OP with "coupling concerns".

@SamuAlfageme SamuAlfageme changed the title Unify server-side filtering endpoints Provide additional oc:filter options for clients May 29, 2018
@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@stale
Copy link

stale bot commented Sep 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants