🐛 hide entity name when a single entity is selected in multi-indicator line and slope charts #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r line and slope charts
sophiamersmann
force-pushed
the
line-chart-label-entity-name
branch
from
344cc8f to
35a6654
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 5 (197a1e) ❌ Edited: 2025-02-26 17:18:39 UTC |
sophiamersmann
requested review from
marcelgerber
and removed request for
marcelgerber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4600
I agree with Pablo R that not showing the entity name is the better default if a single entity is selected (regardless of the entity selection setting).
I can see in the code that showing the entity name in such cases was a deliberate choice, but
I can't think of a good reason.We persist the series name in the URL, so ideally the series name of a line shouldn't change throughout a session. Working on a solution...