Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all unnecessary usage of BAKED_BASE_URL throughout the site. #4524

Open
ikesau opened this issue Feb 5, 2025 · 0 comments
Open

Remove all unnecessary usage of BAKED_BASE_URL throughout the site. #4524

ikesau opened this issue Feb 5, 2025 · 0 comments

Comments

@ikesau
Copy link
Member

ikesau commented Feb 5, 2025

Slack discussion

In many locations, we construct an absolute URL using the BAKED_BASE_URL env variable, for (it seems) almost no point.

Marcel points out that it is needed for SVG downloads so that the links work there, and also in the admin gdocs preview in case authors want to QA some of the links in a topic page or something.

But I think we should be able to remove a lot of these instances and nothing will change except the code will get simpler and we'll have one less superstitious practice.

Impact

None on the site, except maybe a regression if it turns out it does have a purpose in one of the places we change

But also a slightly simpler codebase 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants