-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configuration & php artisan config:cache : bug #290
Comments
What exactly is your point with this issue? |
well because by default the configuration file came with a closure, you can't cache the config (make the app crash). So just update the default config with a default implementation of the resolver in a class. |
While having a closure in the configuration won't work once you try to cache, it makes working with the package a bit quicker, having one less thing to worry about at the beginning. Also, the issue is documented in the troubleshooting and settings sections, along with a few issues here on GitHub (#213, #234, #237, #250, #284). I'll keep this one open, to remind me to add a comment about it in the configuration file. |
well I forget to check the troubleshooting guide ;) |
I would like to support the idea that this should be fixed. The configuration file should not cause artifacts or errors working with default Laravel functionality. |
A |
Hi @quetzyg, |
Actual Behaviour
When I use php artisan config:cache, the app crashed.
Expected Behaviour
When I use php artisan config:cache, i would like my app still running.
Steps to Reproduce
install the package with the config file, and run php artisan config:cache
Possible Solutions
Ask them to make closure usable with laravel config?
Until that
implements a OwenIt\Auditing\Contracts\UserResolver with the same content as the closure
More information: laravel/framework#9625
I totally disagree with the comment that config with closure is bad, but for now there is no good solution for it.
The text was updated successfully, but these errors were encountered: