Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning error if uniform size is too big #1

Open
eduardodoria opened this issue Mar 5, 2023 · 2 comments
Open

Returning error if uniform size is too big #1

eduardodoria opened this issue Mar 5, 2023 · 2 comments

Comments

@eduardodoria
Copy link

In this part is interesting to return an error or print if size is too big:

// data size too big?
if ((size_t)data.size > sizeof(SokolRenderCommand::apply_uniforms.buf))
{
return;
}

Can be hard to debug!

@oviano
Copy link
Owner

oviano commented Mar 5, 2023

Yes, that would make sense.

Possible even an assert?

@eduardodoria
Copy link
Author

Possible even an assert?

Yes, Sokol style assert should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants