Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running venom v1.1.0-rc.1 always create a venom.log file even with verbosity = 0 #599

Closed
mlcdf opened this issue Oct 25, 2022 · 4 comments
Closed

Comments

@mlcdf
Copy link
Member

mlcdf commented Oct 25, 2022

Hi there,

I'm testing the release candidate, and I have this unexpected behavior:

  • no matter the verbosity level, a venom.log file is always generated
  • the same venom.log file used to be overridden at every run. It's not the case anymore so you quickly get dozens of venom*.log file in your current dir.
[...]
$ ./venom1.1.0 run tests
          [trac] writing venom.9.log
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 PASS
final status: PASS
$ ./venom1.1.0 run tests
          [trac] writing venom.10.log
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 PASS
final status: PASS
$ ll venom*log | wc -l
35

I tested with the latest stable version (1.0.1), and it worked as expected:

$ ./venom1.0.1 version
Version venom: v1.0.1
$ ./venom1.0.1 run tests
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 SUCCESS
$ ./venom1.0.1 run tests
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 SUCCESS
$ ./venom1.0.1 run tests
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 SUCCESS
$ ./venom1.0.1 run tests -v
          [trac] writing venom.log
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 SUCCESS
$ ./venom1.0.1 run tests -v
          [trac] writing venom.log
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 SUCCESS
$ ./venom1.0.1 run tests -v
          [trac] writing venom.log
 • Title of TestSuite (tests/deploy.yml)
        • TestCase-with-default-value-exec-cmd-Check-if-exit-code-1 SUCCESS
@nqb
Copy link
Contributor

nqb commented Oct 26, 2022

#441

@mlcdf
Copy link
Member Author

mlcdf commented Oct 26, 2022

Okay so the "write in another file every time" is expected. But still, it should not create a log file when the verbosity level is 0 (unspecified) it think?

@yesnault
Copy link
Member

yesnault commented Nov 8, 2022

It is an expected behaviour.
When a test fails, it is regularly necessary to check the log file venom.log, without having to relaunch the full test.
On CI/CD environment, we don't care about the file creation as the 'workspace' is often ephemeral. If you run venom outside the ci/cd, you probably need to manage the log file as you want matching the exit code.
venom run && rm venom*.log

@yesnault yesnault closed this as completed Nov 8, 2022
@mlcdf mlcdf changed the title Running venon v1.1.0-rc.1 always create a venom.log file even with verbosity = 0 Running venom v1.1.0-rc.1 always create a venom.log file even with verbosity = 0 Nov 8, 2022
@mlcdf
Copy link
Member Author

mlcdf commented Nov 8, 2022

Ok thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants