Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error debugging (especially in CI) #595

Closed
mlcdf opened this issue Oct 20, 2022 · 1 comment · Fixed by #617
Closed

Improving error debugging (especially in CI) #595

mlcdf opened this issue Oct 20, 2022 · 1 comment · Fixed by #617
Labels

Comments

@mlcdf
Copy link
Member

mlcdf commented Oct 20, 2022

Hello folks! :)

The info keyword is great, but it always print (even if the test is successful).

It would be very useful to have something that only prints on failure. So that when everything is fine, it does not pollute the output and in case of an error, you have enough info to debug (it's especially true when a test fails in a CI pipeline and only in CI).

Currently the workaround is to perform an "dummy" assertion on systemout/systemerr (result.systemout ShouldEqual "") so that when it fails, you get the output.

At first, I was thinking of the new keyword. But maybe a new verbosity level that prints the all result in case of a failure would be simpler and a lot more convenient.

What do you think? I can try to work on a PR :)

On another note: I've been using venom since I joined OVHcloud a few months ago, and I like it very much. It's a great little piece of software :)

@aabouzaid
Copy link

It would be great to have that.
This change will improve readability a lot and it will be easy to read the output in the CI pipelines at a glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants