From 8ae3de1128cb5986646044ad48b5cc8b4fb4077d Mon Sep 17 00:00:00 2001 From: Guillaume Hyenne Date: Thu, 30 Oct 2025 17:02:53 +0100 Subject: [PATCH] fix(telecom.sms): delete sms classType on batch sms ref: #PRDCOL-247 Signed-off-by: Guillaume Hyenne --- .../modules/sms/src/sms/batches/create/routing.js | 2 -- .../create/telecom-sms-batches-create.component.js | 1 - .../create/telecom-sms-batches-create.controller.js | 6 ------ .../sms/batches/create/translations/Messages_fr_FR.json | 4 ---- .../sms/components/sms-options/sms-options.component.js | 1 - .../sms/src/sms/components/sms-options/sms-options.html | 9 --------- 6 files changed, 23 deletions(-) diff --git a/packages/manager/modules/sms/src/sms/batches/create/routing.js b/packages/manager/modules/sms/src/sms/batches/create/routing.js index 14436829381e..deaaabd31ed5 100644 --- a/packages/manager/modules/sms/src/sms/batches/create/routing.js +++ b/packages/manager/modules/sms/src/sms/batches/create/routing.js @@ -95,8 +95,6 @@ export default /* @ngInject */ ($stateProvider) => { }), {}, ), - smsClasses: /* @ngInject */ (schema) => - schema.models['sms.BatchClassEnum'].enum, breadcrumb: /* @ngInject */ ($translate) => $translate.instant('sms_batches_create_title'), }, diff --git a/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.component.js b/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.component.js index 5d76bbe8d93e..e4c69dbb2071 100644 --- a/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.component.js +++ b/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.component.js @@ -19,7 +19,6 @@ export default { selectedReceivers: '<', senders: '<', service: '<', - smsClasses: '<', trackClick: '<', user: '<', }, diff --git a/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.controller.js b/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.controller.js index 2fce2834ca51..aa30f2ab355e 100644 --- a/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.controller.js +++ b/packages/manager/modules/sms/src/sms/batches/create/telecom-sms-batches-create.controller.js @@ -18,11 +18,6 @@ export default class SmsBatchesCreateController { immediate: true, noStopClause: false, }; - - this.classes = this.smsClasses.map((smsClass) => ({ - label: this.$translate.instant(`sms_options_type_${smsClass}`), - value: smsClass, - })); } static canDisplayEstimation(sms) { @@ -38,7 +33,6 @@ export default class SmsBatchesCreateController { const buildParams = {}; return Object.assign( buildParams, - model.class ? { class: model.class.value } : null, model.sender.sender === SMS_COMPOSE.shortNumber ? { senderForResponse: true } : { from: model.sender.sender }, diff --git a/packages/manager/modules/sms/src/sms/batches/create/translations/Messages_fr_FR.json b/packages/manager/modules/sms/src/sms/batches/create/translations/Messages_fr_FR.json index a7ee5b236a13..ad6f7d816c5d 100644 --- a/packages/manager/modules/sms/src/sms/batches/create/translations/Messages_fr_FR.json +++ b/packages/manager/modules/sms/src/sms/batches/create/translations/Messages_fr_FR.json @@ -34,10 +34,6 @@ "sms_programming": "Programmation de la campagne", "sms_programming_date": "Date :", "sms_programming_time": "Heure :", - "sms_options_type": "Enregistrement du SMS", - "sms_options_type_FLASH": "Flash", - "sms_options_type_PHONE": "Mémoire téléphone", - "sms_options_type_SIM": "Carte SIM", "sms_batches_create_send": "Envoyer", "sms_batches_create_cancel": "Annuler", "sms_credit_balance": "Solde", diff --git a/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.component.js b/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.component.js index 3c6fdd167beb..f9de29aa8845 100644 --- a/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.component.js +++ b/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.component.js @@ -3,7 +3,6 @@ import template from './sms-options.html'; export default { bindings: { - classes: '<', model: '=', }, controller, diff --git a/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.html b/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.html index 6101d7f58cb2..f78e8792959f 100644 --- a/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.html +++ b/packages/manager/modules/sms/src/sms/components/sms-options/sms-options.html @@ -33,12 +33,3 @@

- - - -