Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): disable tabindex on disabled radio #95

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(radio): disable tabindex on disabled radio #95

merged 1 commit into from
Jul 17, 2023

Conversation

skhamvon
Copy link
Contributor

No description provided.

@skhamvon skhamvon requested a review from a team as a code owner July 10, 2023 12:38
@skhamvon skhamvon force-pushed the fix/focus-disabled-radio-ODS-763 branch from 8a05a5e to e434697 Compare July 10, 2023 12:40
@aesteves60
Copy link
Contributor

I think we should checked the disabled in this methods too setButtonTabindex ?

@skhamvon skhamvon force-pushed the fix/focus-disabled-radio-ODS-763 branch from e434697 to 430c7ef Compare July 11, 2023 08:55
@skhamvon skhamvon force-pushed the fix/focus-disabled-radio-ODS-763 branch from 430c7ef to 5fd32f8 Compare July 17, 2023 13:42
@dpellier dpellier merged commit cfb31b6 into master Jul 17, 2023
@dpellier dpellier deleted the fix/focus-disabled-radio-ODS-763 branch July 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpellier dpellier dpellier approved these changes

Assignees

@skhamvon skhamvon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skhamvon @aesteves60 @dpellier