Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clipboard): add tooltip message for confirmation #208

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

skhamvon
Copy link
Contributor

ODS-613

  • Add 2 slot to handle confirmation message
  • Add surface to show the confirmation message as tooltip

@skhamvon skhamvon force-pushed the feat/add-tooltip-to-clipboard branch 4 times, most recently from c7ce13c to 3ec4019 Compare September 26, 2023 13:55
@skhamvon skhamvon marked this pull request as ready for review September 26, 2023 13:59
@skhamvon skhamvon requested a review from a team as a code owner September 26, 2023 13:59
@skhamvon skhamvon force-pushed the feat/add-tooltip-to-clipboard branch from 3ec4019 to b5b5b21 Compare September 27, 2023 12:53
Copy link
Contributor

@aesteves60 aesteves60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to edit the two message in storybook.

  • When no success message we have a tooltip undefined
    image

@skhamvon skhamvon force-pushed the feat/add-tooltip-to-clipboard branch from b5b5b21 to 981047e Compare September 28, 2023 08:36
@skhamvon skhamvon force-pushed the feat/add-tooltip-to-clipboard branch from 66e2707 to d6f220e Compare September 28, 2023 13:27
@astagnol astagnol dismissed dpellier’s stale review October 3, 2023 07:40

Request outdated

@astagnol astagnol merged commit edd9463 into master Oct 3, 2023
@dpellier dpellier deleted the feat/add-tooltip-to-clipboard branch October 4, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants