-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clipboard): add tooltip message for confirmation #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhamvon
force-pushed
the
feat/add-tooltip-to-clipboard
branch
4 times, most recently
from
September 26, 2023 13:55
c7ce13c
to
3ec4019
Compare
skhamvon
force-pushed
the
feat/add-tooltip-to-clipboard
branch
from
September 27, 2023 12:53
3ec4019
to
b5b5b21
Compare
dpellier
previously requested changes
Sep 28, 2023
packages/components/clipboard/src/components/osds-clipboard/core/controller.ts
Outdated
Show resolved
Hide resolved
aesteves60
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/components/clipboard/src/components/osds-clipboard/osds-clipboard.scss
Outdated
Show resolved
Hide resolved
packages/components/clipboard/src/components/osds-clipboard/core/controller.ts
Outdated
Show resolved
Hide resolved
packages/components/clipboard/src/components/osds-clipboard/osds-clipboard.tsx
Outdated
Show resolved
Hide resolved
skhamvon
force-pushed
the
feat/add-tooltip-to-clipboard
branch
from
September 28, 2023 08:36
b5b5b21
to
981047e
Compare
aesteves60
requested changes
Sep 28, 2023
packages/components/clipboard/src/components/osds-clipboard/core/controller.ts
Outdated
Show resolved
Hide resolved
packages/components/clipboard/src/components/osds-clipboard/core/controller.ts
Outdated
Show resolved
Hide resolved
skhamvon
force-pushed
the
feat/add-tooltip-to-clipboard
branch
from
September 28, 2023 13:27
66e2707
to
d6f220e
Compare
aesteves60
approved these changes
Sep 29, 2023
astagnol
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODS-613