fix(api): missing app secret for git checkout with https (#5833)

Author: richardlt

engine/api/workflow_run.go

@@ -1225,7 +1225,7 @@ func saveWorkflowRunSecrets(ctx context.Context, db *gorp.DbMap, projID int64, w
 		for _, v := range variables {
 			var wrSecret sdk.WorkflowRunSecret
 			switch {
-			case strings.HasPrefix(v.Name, "cds.app.") || strings.HasPrefix(v.Name, "cds.key."):
+			case strings.HasPrefix(v.Name, "cds.app.") || strings.HasPrefix(v.Name, "cds.key.") || v.Name == "git.http.password":
 				wrSecret = sdk.WorkflowRunSecret{
 					WorkflowRunID: wr.ID,
 					Context:       fmt.Sprintf(workflow.SecretAppContext, id),

sdk/parameter.go

@@ -300,7 +300,7 @@ func ParametersMerge(src []Parameter, overwritter []Parameter) []Parameter {
 	return params
 }
 
-// ParametersMapMerge merges two maps of parameters preserving all git values
+// ParametersMapMerge merges two maps of parameters
 func ParametersMapMerge(params map[string]string, otherParams map[string]string, checkFuncs ...func(string) bool) map[string]string {
 	for k, overrideValue := range otherParams {
 		if _, ok := params[k]; ok {