Skip to content

Commit 7d031e4

Browse files
authored
fix(api): let hooks call getWorkflowJobHookDetailsHandler (#6143)
Signed-off-by: francois samin <[email protected]>
1 parent a7b6450 commit 7d031e4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

engine/api/api_routes.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ func (api *API) InitRouter() {
290290
r.Handle("/project/{key}/workflows/{permWorkflowName}/triggers/condition", Scope(sdk.AuthConsumerScopeRun), r.GET(api.getWorkflowTriggerConditionHandler))
291291
r.Handle("/project/{key}/workflows/{permWorkflowName}/runs/{number}/nodes/{nodeRunID}/release", Scope(sdk.AuthConsumerScopeRunExecution), r.POSTEXECUTE(api.releaseApplicationWorkflowHandler, MaintenanceAware()))
292292
r.Handle("/project/{key}/workflows/{permWorkflowNameAdvanced}/runs/{number}/hooks/{hookRunID}/callback", Scope(sdk.AuthConsumerScopeRun), r.POST(api.postWorkflowJobHookCallbackHandler, MaintenanceAware()))
293-
r.Handle("/project/{key}/workflows/{permWorkflowName}/runs/{number}/hooks/{hookRunID}/details", Scope(sdk.AuthConsumerScopeRun), r.GET(api.getWorkflowJobHookDetailsHandler))
293+
r.Handle("/project/{key}/workflows/{permWorkflowNameAdvanced}/runs/{number}/hooks/{hookRunID}/details", Scope(sdk.AuthConsumerScopeRun), r.GET(api.getWorkflowJobHookDetailsHandler))
294294

295295
// Environment
296296
r.Handle("/project/{permProjectKey}/environment", Scope(sdk.AuthConsumerScopeProject), r.GET(api.getEnvironmentsHandler), r.POST(api.addEnvironmentHandler))

engine/api/workflow_hook.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ func (api *API) getWorkflowJobHookDetailsHandler() service.Handler {
325325
return func(ctx context.Context, w http.ResponseWriter, r *http.Request) error {
326326
vars := mux.Vars(r)
327327
key := vars["key"]
328-
workflowName := vars["permWorkflowName"]
328+
workflowName := vars["permWorkflowNameAdvanced"]
329329
hookRunID := vars["hookRunID"]
330330
number, errnum := requestVarInt(r, "number")
331331
if errnum != nil {

0 commit comments

Comments
 (0)