fix(api): allow to stop a workflow run marked as to delete (#5207)

richardlt · web-flow · commit 71bb5bf50a44 · 2020-05-27T09:34:10.000+02:00
diff --git a/engine/api/workflow_run.go b/engine/api/workflow_run.go
@@ -348,9 +348,11 @@ func (api *API) stopWorkflowRunHandler() service.Handler {
 			return err
 		}
 
-		run, errL := workflow.LoadRun(ctx, api.mustDB(), key, name, number, workflow.LoadRunOptions{})
-		if errL != nil {
-			return sdk.WrapError(errL, "stopWorkflowRunHandler> Unable to load last workflow run")
+		run, err := workflow.LoadRun(ctx, api.mustDB(), key, name, number, workflow.LoadRunOptions{
+			WithDeleted: true,
+		})
+		if err != nil {
+			return sdk.WrapError(err, "unable to load last workflow run")
 		}
 
 		proj, errP := project.Load(api.mustDB(), key)

Original file line number	Diff line number	Diff line change
`@@ -348,9 +348,11 @@ func (api *API) stopWorkflowRunHandler() service.Handler {`
`348`	`348`	`return err`
`349`	`349`	`}`
`350`	`350`
`351`		`- run, errL := workflow.LoadRun(ctx, api.mustDB(), key, name, number, workflow.LoadRunOptions{})`
`352`		`- if errL != nil {`
`353`		`- return sdk.WrapError(errL, "stopWorkflowRunHandler> Unable to load last workflow run")`
	`351`	`+ run, err := workflow.LoadRun(ctx, api.mustDB(), key, name, number, workflow.LoadRunOptions{`
	`352`	`+ WithDeleted: true,`
	`353`	`+ })`
	`354`	`+ if err != nil {`
	`355`	`+ return sdk.WrapError(err, "unable to load last workflow run")`
`354`	`356`	`}`
`355`	`357`
`356`	`358`	`proj, errP := project.Load(api.mustDB(), key)`