Skip to content

Commit 1de9f1f

Browse files
authored
perf(ui): update loader (#5029)
* perf(ui): update loader Signed-off-by: Yvonnick Esnault <[email protected]>
1 parent 4077bb8 commit 1de9f1f

File tree

4 files changed

+2
-7
lines changed

4 files changed

+2
-7
lines changed

ui/src/app/shared/status/status.component.ts

-2
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import { PipelineStatus } from 'app/model/pipeline.model';
99
})
1010
export class StatusIconComponent {
1111
@Input() status: string;
12-
@Input() value: string;
1312
@Input() optional: boolean;
14-
@Input() loader = true;
1513
pipelineStatusEnum = PipelineStatus;
1614

1715
constructor() { }

ui/src/app/shared/status/status.icon.html

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
<div class="status-icon" [ngSwitch]="status">
22
<div class="wrapper">
33
<ng-container *ngSwitchCase="pipelineStatusEnum.BUILDING">
4-
<div *ngIf="loader" class="ui small active inline blue loader">
5-
<span class="">{{value}}</span>
6-
</div>
7-
<i *ngIf="!loader" class="blue circle outline icon"></i>
4+
<img id="gifloader" height="24" width="24" src="/assets/images/loader.gif">
85
</ng-container>
96
<i class="check green icon" *ngSwitchCase="pipelineStatusEnum.SUCCESS"></i>
107
<ng-container *ngSwitchCase="pipelineStatusEnum.FAIL">

ui/src/app/shared/status/status.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ describe('CDS: Parameter Value Component', () => {
4444
tick(50);
4545

4646
let compiled = fixture.debugElement.nativeElement;
47-
expect(compiled.querySelector('.blue.loader')).toBeTruthy('Building loader not displayed');
47+
expect(compiled.querySelector('#gifloader')).toBeTruthy('Building loader not displayed');
4848
}));
4949

5050
it('should display fail icon', fakeAsync(() => {

ui/src/assets/images/loader.gif

6.11 KB
Loading

0 commit comments

Comments
 (0)