Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增硬件设备api #529

Merged
merged 3 commits into from
Nov 25, 2016
Merged

新增硬件设备api #529

merged 3 commits into from
Nov 25, 2016

Conversation

soone
Copy link
Contributor

@soone soone commented Nov 25, 2016

No description provided.

'event' => 1048576,
'device_event' => 256,
'device_text' => 512,
'event' => 1049598,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event 改错了吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦,这个地方我以为是event是根据上面的数值总和的,,所以改了event的值

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我加了256和512,所以就把event的值也重新计算了。。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是 2 的指数结果啊

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2^20 = 1048576, 换句话说,你不管改不改,它应该要与上面的常量一致:const EVENT_MSG = 1048576;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你把它改成了 ALL_MSG 的值

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event那个确实改错了,,你拒绝吧,我改回来重新提交

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soone 这个 map 的作用是把小写英文与 上面的常量建立对应关系,event 我选了一个较大的值是因为考虑后期拓展,比如你添加的 device_event device_text, 给他们留位置

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soone 你直接修改提交就好了 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那ALL_MSG的值是不是也是错了?

@overtrue overtrue merged commit 3bf7f49 into w7corp:master Nov 25, 2016
@overtrue
Copy link
Collaborator

是否有兴趣补一下使用文档呢?https://github.com/easywechat/docs 😆

@soone
Copy link
Contributor Author

soone commented Nov 25, 2016

好啊,,不过得后面,,现在赶项目,我会抽时间补上的,先fork过来

@overtrue
Copy link
Collaborator

overtrue commented Nov 25, 2016

@soone 感谢! ❤️

@overtrue overtrue mentioned this pull request Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants