better implementation for prepare oauth callback url #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,9 +71,10 @@ public function register(Container $pimple) | |||
| private function prepareCallbackUrl($pimple) | |||
| { | |||
| $callback = $pimple['config']->get('oauth.callback'); | |||
| if (false !== strpos($callback, ':')) { | |||
There was a problem hiding this comment.
建议判断http 而不是 :， 因为端口也是用:号来区别的
|
确实考虑欠佳，不过又厚颜无耻的改了下这段代码 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.