Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The implementation class of ServerServiceProvider missing an important #244

Closed
motionlife opened this issue Jan 15, 2016 · 1 comment
Closed

Comments

@motionlife
Copy link

In the Guard class, line #324, it seems that you forgot to declare the property of messageFilter, which caused the dysfunction of received message type-filtering.

protected function handleMessage($message)
{
$handler = $this->messageHandler;

    if (!is_callable($handler)) {
        Log::debug('No handler enabled.');

        return;
    }

    Log::debug('Message detail:', $message);

    $message = new Collection($message);

    $type = $this->messageTypeMapping[$message->get('MsgType')];

    $response = null;

    // forgot to declare the property of messageFilter?
    if ($this->messageFilter & $type) {
        $response = call_user_func_array($handler, [$message]);
    }

    return $response;
}
overtrue added a commit that referenced this issue Jan 15, 2016
@overtrue
Copy link
Collaborator

@motionlife Thanks.

overtrue added a commit that referenced this issue Jan 15, 2016
overtrue added a commit that referenced this issue Jan 15, 2016
overtrue added a commit that referenced this issue Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants